Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MsWheaPkg: Add Rust Telemetry helper library #611

Merged
merged 10 commits into from
Dec 3, 2024

Conversation

zurcher
Copy link
Contributor

@zurcher zurcher commented Nov 25, 2024

Description

This adds a rust version of the existing MuTelemetryHelperLib

  • Impacts functionality?
  • Impacts security?
  • Breaking change?
  • Includes tests?
  • Includes documentation?
  • Backport to release branch?

How This Was Tested

Rust unit tests covering the correct propagation of data through the log_telemetry and report_status_code interfaces, as well as data struct size checks and a coverage check.

Integration Instructions

Parent driver must call init_telemetry once, and can then call log_telemetry as needed.

@github-actions github-actions bot added impact:non-functional Does not have a functional impact impact:testing Affects testing type:documentation Improvements or additions to documentation labels Nov 25, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 11.59%. Comparing base (cec06c3) to head (ca412f9).

Additional details and impacted files
@@             Coverage Diff             @@
##           dev/202405     #611   +/-   ##
===========================================
  Coverage       11.59%   11.59%           
===========================================
  Files             132      132           
  Lines           21561    21561           
  Branches         2546     2546           
===========================================
  Hits             2499     2499           
  Misses          19028    19028           
  Partials           34       34           
Flag Coverage Δ
AdvLoggerPkg 6.07% <ø> (ø)
HidPkg 2.80% <ø> (ø)
MfciPkg 41.21% <ø> (ø)
MsCorePkg 1.44% <ø> (ø)
MsWheaPkg 7.25% <ø> (ø)
XmlSupportPkg 27.64% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zurcher zurcher force-pushed the telemetry branch 3 times, most recently from c734855 to 987d096 Compare November 26, 2024 22:14
@zurcher zurcher requested a review from os-d November 27, 2024 00:43
@makubacki makubacki merged commit 239f3ee into microsoft:dev/202405 Dec 3, 2024
28 checks passed
@makubacki makubacki added the type:backport Backport changes in a dev branch PR to its release branch. label Dec 3, 2024
ProjectMuBot pushed a commit that referenced this pull request Dec 3, 2024
## Description

This adds a rust version of the existing MuTelemetryHelperLib

- [ ] Impacts functionality?
- [ ] Impacts security?
- [ ] Breaking change?
- [x] Includes tests?
- [x] Includes documentation?
- [ ] Backport to release branch?

## How This Was Tested

Rust unit tests covering the correct propagation of data through the
log_telemetry and report_status_code interfaces, as well as data struct
size checks and a coverage check.

## Integration Instructions

Parent driver must call `init_telemetry` once, and can then call
`log_telemetry` as needed.
@makubacki makubacki removed the type:backport Backport changes in a dev branch PR to its release branch. label Dec 3, 2024
@zurcher zurcher deleted the telemetry branch December 3, 2024 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact:non-functional Does not have a functional impact impact:testing Affects testing type:documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants