-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MsWheaPkg: Add Rust Telemetry helper library #611
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
impact:non-functional
Does not have a functional impact
impact:testing
Affects testing
type:documentation
Improvements or additions to documentation
labels
Nov 25, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev/202405 #611 +/- ##
===========================================
Coverage 11.59% 11.59%
===========================================
Files 132 132
Lines 21561 21561
Branches 2546 2546
===========================================
Hits 2499 2499
Misses 19028 19028
Partials 34 34
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
os-d
approved these changes
Nov 26, 2024
MsWheaPkg/Crates/RustMuTelemetryHelperLib/src/status_code_runtime.rs
Outdated
Show resolved
Hide resolved
apop5
approved these changes
Nov 26, 2024
zurcher
force-pushed
the
telemetry
branch
3 times, most recently
from
November 26, 2024 22:14
c734855
to
987d096
Compare
makubacki
reviewed
Nov 27, 2024
os-d
approved these changes
Nov 27, 2024
makubacki
approved these changes
Nov 27, 2024
makubacki
reviewed
Dec 2, 2024
makubacki
added
the
type:backport
Backport changes in a dev branch PR to its release branch.
label
Dec 3, 2024
ProjectMuBot
pushed a commit
that referenced
this pull request
Dec 3, 2024
## Description This adds a rust version of the existing MuTelemetryHelperLib - [ ] Impacts functionality? - [ ] Impacts security? - [ ] Breaking change? - [x] Includes tests? - [x] Includes documentation? - [ ] Backport to release branch? ## How This Was Tested Rust unit tests covering the correct propagation of data through the log_telemetry and report_status_code interfaces, as well as data struct size checks and a coverage check. ## Integration Instructions Parent driver must call `init_telemetry` once, and can then call `log_telemetry` as needed.
makubacki
removed
the
type:backport
Backport changes in a dev branch PR to its release branch.
label
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
impact:non-functional
Does not have a functional impact
impact:testing
Affects testing
type:documentation
Improvements or additions to documentation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds a rust version of the existing MuTelemetryHelperLib
How This Was Tested
Rust unit tests covering the correct propagation of data through the log_telemetry and report_status_code interfaces, as well as data struct size checks and a coverage check.
Integration Instructions
Parent driver must call
init_telemetry
once, and can then calllog_telemetry
as needed.