Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MsBootHttp4 MsBootHttp6 boot sequence #610

Merged

Conversation

kanechen66
Copy link
Contributor

@kanechen66 kanechen66 commented Nov 17, 2024

Description

This change adds MsBootHttp4 MsBootHttp6 so that platform can choose boot device with ipv4/v6 http device.

  • Impacts functionality?
  • Impacts security?
  • Breaking change?
  • Includes tests?
  • Includes documentation?
  • Backport to release branch?

How This Was Tested

Tested on SUT and it can boot to http ip v4 and http ipv6 device.

Integration Instructions

None

@github-actions github-actions bot added the impact:non-functional Does not have a functional impact label Nov 17, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 11.43%. Comparing base (239f3ee) to head (d1bff28).

Additional details and impacted files
@@              Coverage Diff               @@
##           dev/202405     #610      +/-   ##
==============================================
- Coverage       11.59%   11.43%   -0.16%     
==============================================
  Files             132      142      +10     
  Lines           21561    21849     +288     
  Branches         2546     2546              
==============================================
  Hits             2499     2499              
- Misses          19028    19316     +288     
  Partials           34       34              
Flag Coverage Δ
MfciPkg 41.21% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kanechen66 kanechen66 force-pushed the user/kanechen/network_boot_order branch from d616da4 to 0d4b276 Compare November 18, 2024 03:00
@kanechen66 kanechen66 force-pushed the user/kanechen/network_boot_order branch from 0d4b276 to 10230c4 Compare November 18, 2024 05:24
@apop5 apop5 requested a review from kuqin12 November 19, 2024 17:59
@github-actions github-actions bot added the type:backport Backport changes in a dev branch PR to its release branch. label Dec 3, 2024
@apop5 apop5 merged commit 8c274a5 into microsoft:dev/202405 Dec 3, 2024
30 checks passed
ProjectMuBot pushed a commit that referenced this pull request Dec 3, 2024
## Description

This change adds MsBootHttp4 MsBootHttp6 so that platform can choose
boot device with ipv4/v6 http device.

- [ ] Impacts functionality?
- [ ] Impacts security?
- [ ] Breaking change?
- [ ] Includes tests?
- [ ] Includes documentation?
- [x] Backport to release branch?

## How This Was Tested

Tested on SUT and it can boot to http ip v4 and http ipv6 device.

## Integration Instructions

None
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact:non-functional Does not have a functional impact type:backport Backport changes in a dev branch PR to its release branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants