UefiHidDxeV2: Remove mutable static shared reference #593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makubacki
added
the
semver:patch
github-actions
bot
added
the
impact:non-functional
Javagedes
approved these changes
Oct 1, 2024
vineelko
approved these changes
Oct 1, 2024
makubacki
force-pushed
the
uefihiddxev2_addrof
branch
from
2acd5ab to
69b4a00
Compare
vineelko
approved these changes
Oct 1, 2024
|
This PR has been automatically marked as stale because it has not had activity in 60 days. It will be closed if no further activity occurs within 7 days. Thank you for your contributions. |
kuqin12
approved these changes
Dec 3, 2024
makubacki
force-pushed
the
uefihiddxev2_addrof
branch
from
69b4a00 to
a48d1bf
Compare
Use `addr_of!()` (raw pointer) to prevent a reference being created
to the mutable static variable.
```
= note: this will be a hard error in the 2024 edition
= note: this shared reference has lifetime `'static`, but if the
static ever gets mutated, or a mutable reference is
created, then any further use of this shared reference is
Undefined Behavior
```
Signed-off-by: Michael Kubacki <[email protected]>
makubacki
force-pushed
the
uefihiddxev2_addrof
branch
from
a48d1bf to
af71887
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev/202405 #593 +/- ##
===========================================
Coverage 11.59% 11.59%
===========================================
Files 132 132
Lines 21561 21561
Branches 2546 2546
===========================================
Hits 2499 2499
Misses 19028 19028
Partials 34 34
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
vineelko
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use
addr_of!()(raw pointer) to prevent a reference being created to the mutable static variable.How This Was Tested
Integration Instructions