AdvLoggerPkg: Clarify BaseArm instance of AdvLoggerLib #591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The BaseArm instance of AdvLoggerLib has drifted in usage over time from being a BASE instance to an MM_STANDALONE instance. This patch updates comments (and a license while we are there) to indicate usage and restricts its usage to MM_STANDALONE.
1 task
github-actions
bot
added
the
impact:non-functional
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev/202405 #591 +/- ##
===========================================
Coverage 11.40% 11.40%
===========================================
Files 145 145
Lines 21915 21915
Branches 2546 2546
===========================================
Hits 2499 2499
Misses 19382 19382
Partials 34 34
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
makubacki
approved these changes
Sep 30, 2024
apop5
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The BaseArm instance of AdvLoggerLib has drifted in usage over time from being a BASE instance to an MM_STANDALONE instance. This patch updates comments (and a license while we are there) to indicate usage and restricts its usage to MM_STANDALONE.
How This Was Tested
CI.
Integration Instructions
N/A.