Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AdvLoggerPkg: Run CI for AARCH64 #590

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

os-d
Copy link
Contributor

@os-d os-d commented Sep 30, 2024

Description

AdvLoggerPkg.dsc was not setup to run CI for AARCH64 and as a result the ARM64 parts of this pkg were broken. This commit fixes the various build and CI breaks and enables CI for AARCH64 in AdvLoggerPkg.

  • Impacts functionality?
  • Impacts security?
  • Breaking change?
  • Includes tests?
  • Includes documentation?

How This Was Tested

CI builds.

Integration Instructions

N/A.

AdvLoggerPkg.dsc was not setup to run CI for AARCH64 and as a result
the ARM64 parts of this pkg were broken. This commit fixes the various
build and CI breaks and enables CI for AARCH64 in AdvLoggerPkg.
@os-d os-d requested review from makubacki, kuqin12 and apop5 September 30, 2024 20:06
@github-actions github-actions bot added the impact:non-functional Does not have a functional impact label Sep 30, 2024
@os-d os-d enabled auto-merge (rebase) September 30, 2024 20:13
@codecov-commenter
Copy link

codecov-commenter commented Sep 30, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 11.02%. Comparing base (602574c) to head (3ea0216).
Report is 1 commits behind head on release/202311.

Files with missing lines Patch % Lines
...rary/AdvancedLoggerLib/DxeCore/AdvancedLoggerLib.c 0.00% 1 Missing ⚠️
...brary/AdvancedLoggerLib/MmCore/AdvancedLoggerLib.c 0.00% 1 Missing ⚠️
...rary/AdvancedLoggerLib/Runtime/AdvancedLoggerLib.c 0.00% 1 Missing ⚠️
...rary/AdvancedLoggerLib/SmmCore/AdvancedLoggerLib.c 0.00% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           release/202311     #590   +/-   ##
===============================================
  Coverage           11.02%   11.02%           
===============================================
  Files                 144      144           
  Lines               22065    22065           
  Branches             2356     2356           
===============================================
  Hits                 2432     2432           
  Misses              19601    19601           
  Partials               32       32           
Flag Coverage Δ
AdvLoggerPkg 3.60% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@os-d os-d merged commit 94d07e2 into microsoft:release/202311 Sep 30, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact:non-functional Does not have a functional impact
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants