Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AdvLoggerPkg: Run AARCH64 CI #585

Merged
merged 1 commit into from
Sep 30, 2024
Merged

Conversation

os-d
Copy link
Contributor

@os-d os-d commented Sep 27, 2024

Description

AdvLoggerPkg.dsc was not setup to run CI for AARCH64 and as a result the ARM64 parts of this pkg were broken. This commit fixes the various build and CI breaks and enables CI for AARCH64 in AdvLoggerPkg.

  • Impacts functionality?
  • Impacts security?
  • Breaking change?
  • Includes tests?
  • Includes documentation?

How This Was Tested

AARCH64 CI now passes.

Integration Instructions

N/A.

@os-d os-d requested review from makubacki, kuqin12 and apop5 September 27, 2024 23:03
@github-actions github-actions bot added the impact:non-functional Does not have a functional impact label Sep 27, 2024
@makubacki makubacki added the type:bug Something isn't working label Sep 27, 2024
AdvLoggerPkg.dsc was not setup to run CI for AARCH64 and as a result
the ARM64 parts of this pkg were broken. This commit fixes the various
build and CI breaks and enables CI for AARCH64 in AdvLoggerPkg.
@os-d os-d changed the title [SQUASH ON REBASE]AdvLoggerPkg: BaseArm: Fix Typo AdvLoggerPkg: Run AARCH64 CI Sep 30, 2024
@github-actions github-actions bot added the impact:testing Affects testing label Sep 30, 2024
@codecov-commenter
Copy link

codecov-commenter commented Sep 30, 2024

Codecov Report

Attention: Patch coverage is 12.50000% with 14 lines in your changes missing coverage. Please review.

Project coverage is 11.40%. Comparing base (8e7aad7) to head (63ffab9).

Files with missing lines Patch % Lines
...rary/AdvancedLoggerLib/DxeCore/AdvancedLoggerLib.c 14.28% 6 Missing ⚠️
...rary/AdvancedLoggerLib/PeiCore/AdvancedLoggerLib.c 0.00% 6 Missing ⚠️
...rary/AdvancedLoggerLib/Runtime/AdvancedLoggerLib.c 0.00% 1 Missing ⚠️
...rary/AdvancedLoggerLib/SmmCore/AdvancedLoggerLib.c 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           dev/202405     #585   +/-   ##
===========================================
  Coverage       11.40%   11.40%           
===========================================
  Files             145      145           
  Lines           21915    21915           
  Branches         2546     2546           
===========================================
  Hits             2499     2499           
  Misses          19382    19382           
  Partials           34       34           
Flag Coverage Δ
AdvLoggerPkg 6.05% <12.50%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@os-d os-d merged commit cae875f into microsoft:dev/202405 Sep 30, 2024
32 checks passed
@os-d os-d deleted the fix_base_arm branch September 30, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact:non-functional Does not have a functional impact impact:testing Affects testing type:bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants