AdvLoggerPkg: Add AdvancedLoggerMmCoreGoogleTest #577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
impact:non-functional
VivianNK
force-pushed
the
personal/vnowkakeane/advloggertestmmcore
branch
from
d727637 to
1bb79b6
Compare
apop5
reviewed
Sep 19, 2024
AdvLoggerPkg/Library/AdvancedLoggerLib/MmCore/GoogleTest/AdvancedLoggerMmCoreGoogleTest.cpp
Outdated
Show resolved
Hide resolved
VivianNK
force-pushed
the
personal/vnowkakeane/advloggertestmmcore
branch
from
1bb79b6 to
a8a25b6
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev/202405 #577 +/- ##
==============================================
+ Coverage 11.33% 11.40% +0.06%
==============================================
Files 145 145
Lines 21934 21915 -19
Branches 2529 2546 +17
==============================================
+ Hits 2486 2499 +13
+ Misses 19414 19382 -32
Partials 34 34
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
VivianNK
force-pushed
the
personal/vnowkakeane/advloggertestmmcore
branch
from
1833e53 to
34e3a41
Compare
os-d
reviewed
Sep 20, 2024
AdvLoggerPkg/Library/AdvancedLoggerLib/MmCore/AdvancedLoggerLib.c
Outdated
Show resolved
Hide resolved
AdvLoggerPkg/Library/AdvancedLoggerLib/MmCore/AdvancedLoggerLib.c
Outdated
Show resolved
Hide resolved
AdvLoggerPkg/Library/AdvancedLoggerLib/MmCore/GoogleTest/AdvancedLoggerMmCoreGoogleTest.cpp
Outdated
Show resolved
Hide resolved
AdvLoggerPkg/Library/AdvancedLoggerLib/MmCore/GoogleTest/AdvancedLoggerMmCoreGoogleTest.cpp
Show resolved
Hide resolved
VivianNK
force-pushed
the
personal/vnowkakeane/advloggertestmmcore
branch
2 times, most recently
from
354fce2 to
e6e6da2
Compare
VivianNK
force-pushed
the
personal/vnowkakeane/advloggertestmmcore
branch
from
e6e6da2 to
fa22d31
Compare
os-d
approved these changes
Sep 24, 2024
apop5
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add unit test for AdvancedLoggerLib for Mm Core.
Moved changes to the library to this PR: #582
This PR is dependent on those changes and will be rebased after 582 is merged.
How This Was Tested
CI
Integration Instructions
N/A