AdvLoggerPkg: Add GoogleTest for AdvancedLoggerPeiCoreLib #576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
impact:non-functional
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev/202405 #576 +/- ##
==============================================
+ Coverage 11.21% 11.33% +0.12%
==============================================
Files 145 145
Lines 22057 21931 -126
Branches 2450 2529 +79
==============================================
+ Hits 2473 2486 +13
+ Misses 19550 19411 -139
Partials 34 34
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
VivianNK
force-pushed
the
personal/vnowkakeane/advloggertestpeicore
branch
from
a5a5470 to
bba86c3
Compare
VivianNK
force-pushed
the
personal/vnowkakeane/advloggertestpeicore
branch
from
bba86c3 to
53587cd
Compare
apop5
reviewed
Sep 17, 2024
AdvLoggerPkg/Library/AdvancedLoggerLib/PeiCore/GoogleTest/AdvancedLoggerPeiCoreLib.cpp
Outdated
Show resolved
Hide resolved
VivianNK
force-pushed
the
personal/vnowkakeane/advloggertestpeicore
branch
from
4050972 to
5b64a08
Compare
VivianNK
force-pushed
the
personal/vnowkakeane/advloggertestpeicore
branch
from
5b64a08 to
21bbba7
Compare
apop5
approved these changes
Sep 19, 2024
kenlautner
approved these changes
Sep 19, 2024
VivianNK
added a commit
that referenced
this pull request
Sep 23, 2024
## Description Add basic GoogleTest for AdvancedLoggerPeiCoreLib - [ ] Impacts functionality? - [ ] Impacts security? - [ ] Breaking change? - [x] Includes tests? - [ ] Includes documentation? ## How This Was Tested CI ## Integration Instructions N/A
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add basic GoogleTest for AdvancedLoggerPeiCoreLib
How This Was Tested
CI
Integration Instructions
N/A