[Cherry-Pick] Bring in last of 202311 changes into 202405 #563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e entries - Driver implementation (microsoft#525) Add debug level prefix for advanced logger memory message entries - Driver implementation This change added the existing metadata - debug level into the final advanced logger memory entries through AdvancedFileLogger. This is a followup PR for microsoft@243bd18. After this PR checked in, we can easily track the DEBUG_ERRORs through advanced logger files on UEFI that included this driver. Added an extra space in the decodeuefilog.py to improve readability of the log. For the for loop in the code, ran with perf_trace enabled, and influence is very low and can be ignored. Updated the prefix of python script to match the design here. Use [ERROR] instead of [DEBUG_ERROR], which could save overall log file sizes and memory buffer usage. - [x] Impacts functionality? - **Functionality** - Does the change ultimately impact how firmware functions? - Examples: Add a new library, publish a new PPI, update an algorithm, ... - [ ] Impacts security? - **Security** - Does the change have a direct security impact on an application, flow, or firmware? - Examples: Crypto algorithm change, buffer overflow fix, parameter validation improvement, ... - [ ] Breaking change? - **Breaking change** - Will anyone consuming this change experience a break in build or boot behavior? - Examples: Add a new library class, move a module to a different repo, call a function in a new library class in a pre-existing module, ... - [ ] Includes tests? - **Tests** - Does the change include any explicit test code? - Examples: Unit tests, integration tests, robot tests, ... - [ ] Includes documentation? - **Documentation** - Does the change contain explicit documentation additions outside direct code modifications (and comments)? - Examples: Update readme file, add feature readme file, link to documentation on an a separate Web page, ... Tested with two platforms that uses AdvancedFileLogger and can see debug level prefixes in the logs in the EFI Partition and USB UefiLogs folder. [MM_CORE] [ERROR] Image - MmSupervisorCore.pdb N/A
microsoft#500) There are multiple copies of VariableSupportLib floating across repos, mostly only supporting Windows. Functionality has been consolidated into edk2-pytool-library version 0.21.7. Support for Linux has been added. Switch MfciPolicy.py, DecodeUefiLog.py and UefiVarAudit.py to use consolidated version from edk2-pytool-library. Removed local copies of VariableSupportLib.py - [x] Impacts functionality? - **Functionality** - Does the change ultimately impact how firmware functions? - Examples: Add a new library, publish a new PPI, update an algorithm, ... - [ ] Impacts security? - **Security** - Does the change have a direct security impact on an application, flow, or firmware? - Examples: Crypto algorithm change, buffer overflow fix, parameter validation improvement, ... - [ ] Breaking change? - **Breaking change** - Will anyone consuming this change experience a break in build or boot behavior? - Examples: Add a new library class, move a module to a different repo, call a function in a new library class in a pre-existing module, ... - [ ] Includes tests? - **Tests** - Does the change include any explicit test code? - Examples: Unit tests, integration tests, robot tests, ... - [ ] Includes documentation? - **Documentation** - Does the change contain explicit documentation additions outside direct code modifications (and comments)? - Examples: Update readme file, add feature readme file, link to documentation on an a separate Web page, ... N/A
… Load Option's list box (microsoft#552) Fixes microsoft#554 - Adjusted CellTrashcanBounds.Left to be CellBounds->Right - TrashcanHitAreaWidth to ensure the trash can icon is displayed to the right of the list box. - Updated width parameter in SWM_RECT_INIT2 to use TrashcanHitAreaWidth instead of CheckBoxHitAreaWidth for correct dimensions. This resolves the issue of the trash can icon overlapping with the ListBox's deletable item's checkbox thus ensuring its related operations work correctly: activating/deactivating the Load Option or deleting it. Verified that a Load Option allowed to be deleted, such as 'Windows Boot Manager', can now be deleted by pressing the trash icon in its proper position or activated via its check-box. N/A Co-authored-by: Michael Kubacki <[email protected]>
github-actions
bot
added
language:python
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/202405 #563 +/- ##
==================================================
- Coverage 11.03% 11.00% -0.03%
==================================================
Files 145 145
Lines 22166 22226 +60
Branches 2370 2370
==================================================
Hits 2445 2445
- Misses 19688 19748 +60
Partials 33 33
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
makubacki
approved these changes
Aug 27, 2024
os-d
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cherry-Picking changes that went into 202311 into 202405.
How This Was Tested
CI
Integration Instructions
N/A