AdvLoggerPkg: Modify AdvancedLib Dxe initialization. #549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
impact:non-functional
VivianNK
force-pushed
the
personal/vnowkakeane/advloggerdxelib
branch
from
9b58fcb to
0b9bea6
Compare
VivianNK
force-pushed
the
personal/vnowkakeane/advloggerdxelib
branch
from
0b9bea6 to
29bd4ef
Compare
VivianNK
commented
Aug 13, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/202405 #549 +/- ##
=================================================
Coverage ? 11.04%
=================================================
Files ? 144
Lines ? 22022
Branches ? 2355
=================================================
Hits ? 2432
Misses ? 19558
Partials ? 32
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
apop5
changed the title
apop5
approved these changes
Aug 13, 2024
os-d
approved these changes
Aug 13, 2024
kuqin12
approved these changes
Aug 13, 2024
VivianNK
added
type:bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Modify Advanced Logger DXE Library. Detect invalid Advanced Logger Protocol earlier, and allow to fail gracefully and fallback to DebugPortProtocol.
How This Was Tested
Local CI
Integration Instructions
N/A