Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding MuArmGicExLib and update the usage accordingly #548

Merged
merged 13 commits into from
Aug 11, 2024

Conversation

kuqin12
Copy link
Contributor

@kuqin12 kuqin12 commented Aug 10, 2024

Description

This change introduced the MuArmGicExLib into MsCorePkg to host a few interfaces and definitions EDK2 prefer not to support due to lack of active consumers.

The consumers in Project MU (MpManagement driver and app) are updated to use the new interface and library implementation.

  • Impacts functionality?
  • Impacts security?
  • Breaking change?
  • Includes tests?
  • Includes documentation?

How This Was Tested

Tested on pipeline server build.

Integration Instructions

Platforms using MpManagement functionality should include MuArmGicExLib in their DSC file.

@github-actions github-actions bot added the impact:breaking-change Requires integration attention label Aug 10, 2024
@codecov-commenter
Copy link

codecov-commenter commented Aug 10, 2024

Codecov Report

Attention: Patch coverage is 0% with 163 lines in your changes missing coverage. Please review.

Please upload report for BASE (release/202405@eac41ba). Learn more about missing BASE report.

Files Patch % Lines
MsCorePkg/Library/MuArmGicExLib/MuArmGicExLib.c 0.00% 163 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##             release/202405    #548   +/-   ##
================================================
  Coverage                  ?   9.41%           
================================================
  Files                     ?     145           
  Lines                     ?   22044           
  Branches                  ?    2356           
================================================
  Hits                      ?    2075           
  Misses                    ?   19667           
  Partials                  ?     302           
Flag Coverage Δ
MfciPkg 20.01% <ø> (?)
MsCorePkg 0.64% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kuqin12 kuqin12 enabled auto-merge (squash) August 10, 2024 16:50
@kuqin12 kuqin12 merged commit a962688 into microsoft:release/202405 Aug 11, 2024
28 checks passed
@kuqin12 kuqin12 deleted the arm_gic branch August 11, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact:breaking-change Requires integration attention
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants