Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a debug string format specifier. #544

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

joschock
Copy link
Contributor

@joschock joschock commented Aug 7, 2024

Description

Fix an issue where the wrong format specifier was used for an ASCII string.

  • Impacts functionality?
  • Impacts security?
  • Breaking change?
  • Includes tests?
  • Includes documentation?

How This Was Tested

Observed that ID_NOT_FOUND string was properly formatted.

Integration Instructions

N/A

@github-actions github-actions bot added the impact:non-functional Does not have a functional impact label Aug 7, 2024
@makubacki makubacki added the type:bug Something isn't working label Aug 7, 2024
@codecov-commenter
Copy link

codecov-commenter commented Aug 7, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Please upload report for BASE (release/202405@c19eb5f). Learn more about missing BASE report.

Files Patch % Lines
...eIdSupportLibSmbios/MfciDeviceIdSupportLibSmbios.c 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##             release/202405     #544   +/-   ##
=================================================
  Coverage                  ?   11.04%           
=================================================
  Files                     ?      144           
  Lines                     ?    22019           
  Branches                  ?     2356           
=================================================
  Hits                      ?     2432           
  Misses                    ?    19555           
  Partials                  ?       32           
Flag Coverage Δ
MfciPkg 39.37% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@apop5 apop5 merged commit eac41ba into microsoft:release/202405 Aug 7, 2024
28 checks passed
apop5 pushed a commit to apop5/mu_plus that referenced this pull request Aug 7, 2024
## Description

Fix an issue where the wrong format specifier was used for an ASCII
string.

- [ ] Impacts functionality?
- [ ] Impacts security?
- [ ] Breaking change?
- [ ] Includes tests?
- [ ] Includes documentation?

## How This Was Tested

Observed that ID_NOT_FOUND string was properly formatted.

## Integration Instructions

N/A
makubacki pushed a commit to apop5/mu_plus that referenced this pull request Aug 8, 2024
## Description

Fix an issue where the wrong format specifier was used for an ASCII
string.

- [ ] Impacts functionality?
- [ ] Impacts security?
- [ ] Breaking change?
- [ ] Includes tests?
- [ ] Includes documentation?

## How This Was Tested

Observed that ID_NOT_FOUND string was properly formatted.

## Integration Instructions

N/A
makubacki pushed a commit that referenced this pull request Aug 8, 2024
## Description

Fix an issue where the wrong format specifier was used for an ASCII
string.

- [ ] Impacts functionality?
- [ ] Impacts security?
- [ ] Breaking change?
- [ ] Includes tests?
- [ ] Includes documentation?

## How This Was Tested

Observed that ID_NOT_FOUND string was properly formatted.

## Integration Instructions

N/A
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact:non-functional Does not have a functional impact type:bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants