-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix a debug string format specifier. #544
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
impact:non-functional
Does not have a functional impact
label
Aug 7, 2024
apop5
approved these changes
Aug 7, 2024
os-d
approved these changes
Aug 7, 2024
makubacki
approved these changes
Aug 7, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/202405 #544 +/- ##
=================================================
Coverage ? 11.04%
=================================================
Files ? 144
Lines ? 22019
Branches ? 2356
=================================================
Hits ? 2432
Misses ? 19555
Partials ? 32
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
apop5
pushed a commit
to apop5/mu_plus
that referenced
this pull request
Aug 7, 2024
## Description Fix an issue where the wrong format specifier was used for an ASCII string. - [ ] Impacts functionality? - [ ] Impacts security? - [ ] Breaking change? - [ ] Includes tests? - [ ] Includes documentation? ## How This Was Tested Observed that ID_NOT_FOUND string was properly formatted. ## Integration Instructions N/A
makubacki
pushed a commit
to apop5/mu_plus
that referenced
this pull request
Aug 8, 2024
## Description Fix an issue where the wrong format specifier was used for an ASCII string. - [ ] Impacts functionality? - [ ] Impacts security? - [ ] Breaking change? - [ ] Includes tests? - [ ] Includes documentation? ## How This Was Tested Observed that ID_NOT_FOUND string was properly formatted. ## Integration Instructions N/A
makubacki
pushed a commit
that referenced
this pull request
Aug 8, 2024
## Description Fix an issue where the wrong format specifier was used for an ASCII string. - [ ] Impacts functionality? - [ ] Impacts security? - [ ] Breaking change? - [ ] Includes tests? - [ ] Includes documentation? ## How This Was Tested Observed that ID_NOT_FOUND string was properly formatted. ## Integration Instructions N/A
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix an issue where the wrong format specifier was used for an ASCII string.
How This Was Tested
Observed that ID_NOT_FOUND string was properly formatted.
Integration Instructions
N/A