[REBASE & FF] Advanced Logger Cherry-Picks From 202311 #520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…reation Currently, File Logger will only create the UefiLogs directory on the ESP if the device is an NVMe device. This is an unneccesary restriction and is removed in this patch.
This is a very small portion cherry-picked from be9a3d2. This fixes a breakage for ARM64 platforms that initialize AdvLogger in PeiCore, which has a hardcoded assumption that memory is not available at its start (not true for ARM64 platforms) and so allocating a minimum of 16 pages for the runtime granularity will fail. This "pre-mem" buffer gets freed as soon as permanent memory is installed, so we can allocate it as EfiBootServicesData (which does not use the runtime allocation granularity of 64k). This also works on x86. If PcdAdvancedLoggerPeiInRAM is true, we can allocate the full amount and need the correct runtime type (I do not think this feature works, for the reason listed above, but that is outside the scope of this commit).
github-actions
bot
added
the
impact:non-functional
apop5
approved these changes
Jul 11, 2024
makubacki
approved these changes
Jul 11, 2024
kuqin12
approved these changes
Jul 11, 2024
VivianNK
approved these changes
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR cherry-picks one full commit and one very small part of another commit from 202311:
Remove NVMe Check from File Logger
This is a complete cherry-pick from c024ed1. It adds support for File Logger to create the UefiLogs directory on non-NVMe devices.
Allocate AdvLogger Pre-Mem Pages as EfiBootServicesData
This is a part of be9a3d2. The rest of this commit is not taken because it is a new feature (a new version of the AdvLogger structure). This portion of the commit was taken because it is a bugfix for when ARM64 switched over to 64k runtime page allocation granularity. Because PeiCore has a hardcoded assumption it is operating pre-mem, which is not true for ARM64, we cannot allocate a minimum of 16 pages for a runtime type at the start of PeiCore (when AdvLogger is initialized there). We instead need to allocate as EfiBootServicesData (which does not have the runtime page allocation granularity) and reallocate as EfiRuntimeServicesData after permanent memory is installed.
flow, or firmware?
validation improvement, ...
in build or boot behavior?
a function in a new library class in a pre-existing module, ...
outside direct code modifications (and comments)?
on an a separate Web page, ...
How This Was Tested
N/A
Integration Instructions
N/A