Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MsApplicationPkg: Add FBPT Dump App #509

Closed
wants to merge 1 commit into from

Conversation

os-d
Copy link
Contributor

@os-d os-d commented Jul 2, 2024

Description

Simple UEFI app that dumps FBPT into FBPT.bin. This previously lived in mu_basecore in 1c82e08470. However, it lived in an empty package and was not built for CI. Moving this to MsApplicationPkg makes more sense as it can be built in CI and used to verify Performance Data.

This is intended to enter mu_plus with the release/202405 integration, as release/202311 still carries the application.

  • Impacts functionality?
    • Functionality - Does the change ultimately impact how firmware functions?
    • Examples: Add a new library, publish a new PPI, update an algorithm, ...
  • Impacts security?
    • Security - Does the change have a direct security impact on an application,
      flow, or firmware?
    • Examples: Crypto algorithm change, buffer overflow fix, parameter
      validation improvement, ...
  • Breaking change?
    • Breaking change - Will anyone consuming this change experience a break
      in build or boot behavior?
    • Examples: Add a new library class, move a module to a different repo, call
      a function in a new library class in a pre-existing module, ...
  • Includes tests?
    • Tests - Does the change include any explicit test code?
    • Examples: Unit tests, integration tests, robot tests, ...
  • Includes documentation?
    • Documentation - Does the change contain explicit documentation additions
      outside direct code modifications (and comments)?
    • Examples: Update readme file, add feature readme file, link to documentation
      on an a separate Web page, ...

How This Was Tested

From mu_basecore.

Integration Instructions

Include the shell app in your DSC/FDF and run it to get the FBPT dumped out to a binary.

Simple UEFI app that dumps FBPT into FBPT.bin
@os-d os-d requested review from makubacki and apop5 July 2, 2024 22:39
@github-actions github-actions bot added impact:non-functional Does not have a functional impact impact:testing Affects testing labels Jul 2, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jul 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 11.08%. Comparing base (b5aefd3) to head (0284a2e).
Report is 28 commits behind head on release/202311.

Additional details and impacted files
@@               Coverage Diff               @@
##           release/202311     #509   +/-   ##
===============================================
  Coverage           11.08%   11.08%           
===============================================
  Files                 142      142           
  Lines               21936    21936           
  Branches             2356     2356           
===============================================
  Hits                 2432     2432           
  Misses              19472    19472           
  Partials               32       32           
Flag Coverage Δ
AdvLoggerPkg 3.74% <ø> (ø)
MsCorePkg 1.43% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


[Protocols]
gEfiAcpiSdtProtocolGuid
gEfiSmbiosProtocolGuid
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add an empty line to the end of this file.


#include <Uefi.h>
#include <Library/BaseLib.h>
#include <Library/BaseMemoryLib.h>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed BaseMemoryLib and MemoryAllocationLib are not in the INF library classes section. Can you please double check library usage?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the commit is still targeting PerformancePkg. It will also need to be added to the MsApplicationPkg build.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it should target UefiTestingPkg, based from offline conversations.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, the decision was made for UefiTestingPkg. I still consider it more an "application" than a test, but those boundaries are debatable, and the testing package is fine.

Copy link

This PR has been automatically marked as stale because it has not had activity in 60 days. It will be closed if no further activity occurs within 7 days. Thank you for your contributions.

@github-actions github-actions bot added state:stale Has not been updated in a long time and removed state:stale Has not been updated in a long time labels Oct 15, 2024
Copy link

This PR has been automatically marked as stale because it has not had activity in 60 days. It will be closed if no further activity occurs within 7 days. Thank you for your contributions.

@github-actions github-actions bot added the state:stale Has not been updated in a long time label Dec 21, 2024
Copy link

This pull request has been automatically been closed because it did not have any activity in 60 days and no follow up within 7 days after being marked stale. Thank you for your contributions.

@github-actions github-actions bot closed this Dec 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact:non-functional Does not have a functional impact impact:testing Affects testing state:stale Has not been updated in a long time
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants