-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MsApplicationPkg: Add FBPT Dump App #509
Conversation
Simple UEFI app that dumps FBPT into FBPT.bin
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/202311 #509 +/- ##
===============================================
Coverage 11.08% 11.08%
===============================================
Files 142 142
Lines 21936 21936
Branches 2356 2356
===============================================
Hits 2432 2432
Misses 19472 19472
Partials 32 32
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
||
[Protocols] | ||
gEfiAcpiSdtProtocolGuid | ||
gEfiSmbiosProtocolGuid |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add an empty line to the end of this file.
|
||
#include <Uefi.h> | ||
#include <Library/BaseLib.h> | ||
#include <Library/BaseMemoryLib.h> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed BaseMemoryLib
and MemoryAllocationLib
are not in the INF library classes section. Can you please double check library usage?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the commit is still targeting PerformancePkg
. It will also need to be added to the MsApplicationPkg
build.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it should target UefiTestingPkg, based from offline conversations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, the decision was made for UefiTestingPkg
. I still consider it more an "application" than a test, but those boundaries are debatable, and the testing package is fine.
This PR has been automatically marked as stale because it has not had activity in 60 days. It will be closed if no further activity occurs within 7 days. Thank you for your contributions. |
This PR has been automatically marked as stale because it has not had activity in 60 days. It will be closed if no further activity occurs within 7 days. Thank you for your contributions. |
This pull request has been automatically been closed because it did not have any activity in 60 days and no follow up within 7 days after being marked stale. Thank you for your contributions. |
Description
Simple UEFI app that dumps FBPT into FBPT.bin. This previously lived in mu_basecore in 1c82e08470. However, it lived in an empty package and was not built for CI. Moving this to MsApplicationPkg makes more sense as it can be built in CI and used to verify Performance Data.
This is intended to enter mu_plus with the release/202405 integration, as release/202311 still carries the application.
flow, or firmware?
validation improvement, ...
in build or boot behavior?
a function in a new library class in a pre-existing module, ...
outside direct code modifications (and comments)?
on an a separate Web page, ...
How This Was Tested
From mu_basecore.
Integration Instructions
Include the shell app in your DSC/FDF and run it to get the FBPT dumped out to a binary.