Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply more idiomatic Rust patterns in RustAdvancedLoggerDxe #498

Conversation

magravel
Copy link
Contributor

@magravel magravel commented Jun 6, 2024

Description

Use more idiomatic rust pattern and remove the explicitly implementation of Sync and Send since these traits are automatically implemented.

Note: changes in pointer.rs are cause by cargo fmt

  • Impacts functionality?
  • Impacts security?
  • Breaking change?
  • Includes tests?
  • Includes documentation?

How This Was Tested

Ran cargo make test

Integration Instructions

N/A

@github-actions github-actions bot added the impact:non-functional Does not have a functional impact label Jun 6, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jun 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release/202311@e7d98c9). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff                @@
##             release/202311    #498   +/-   ##
================================================
  Coverage                  ?   2.96%           
================================================
  Files                     ?      42           
  Lines                     ?    6540           
  Branches                  ?     133           
================================================
  Hits                      ?     194           
  Misses                    ?    6332           
  Partials                  ?      14           
Flag Coverage Δ
AdvLoggerPkg 3.74% <ø> (?)
HidPkg 2.12% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@magravel magravel marked this pull request as ready for review June 10, 2024 16:11
@makubacki makubacki requested review from Flickdm and os-d June 17, 2024 17:07
@makubacki makubacki changed the title Review RustAdvancedLoggerDxe Update idiomatic Rust patterns in RustAdvancedLoggerDxe Jun 17, 2024
@makubacki makubacki changed the title Update idiomatic Rust patterns in RustAdvancedLoggerDxe Apply more idiomatic Rust patterns in RustAdvancedLoggerDxe Jun 17, 2024
@makubacki makubacki force-pushed the personal/magravel/Review_AdvancedLoggerDxe.Task-4098346 branch from cb26e23 to e7fbc3b Compare June 17, 2024 17:09
@makubacki makubacki enabled auto-merge (squash) June 17, 2024 17:09
@makubacki makubacki merged commit 27c6223 into microsoft:release/202311 Jun 21, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact:non-functional Does not have a functional impact
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants