Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MERGE ON REBASE] Fix Wrong mMaxAddress Calculation in AdvLogger #483

Merged
merged 1 commit into from
May 8, 2024

Conversation

os-d
Copy link
Contributor

@os-d os-d commented May 7, 2024

Description

In two places in the Adv Logger v5 update, the incorrect macro was used to calculate mMaxAddress, which led to the log not being fully printed on some architectures. Fixing these leads to the log to be printed.

For each item, place an "x" in between [ and ] if true. Example: [x].
(you can also check items in the GitHub UI)

  • Impacts functionality?
    • Functionality - Does the change ultimately impact how firmware functions?
    • Examples: Add a new library, publish a new PPI, update an algorithm, ...
  • Impacts security?
    • Security - Does the change have a direct security impact on an application,
      flow, or firmware?
    • Examples: Crypto algorithm change, buffer overflow fix, parameter
      validation improvement, ...
  • Breaking change?
    • Breaking change - Will anyone consuming this change experience a break
      in build or boot behavior?
    • Examples: Add a new library class, move a module to a different repo, call
      a function in a new library class in a pre-existing module, ...
  • Includes tests?
    • Tests - Does the change include any explicit test code?
    • Examples: Unit tests, integration tests, robot tests, ...
  • Includes documentation?
    • Documentation - Does the change contain explicit documentation additions
      outside direct code modifications (and comments)?
    • Examples: Update readme file, add feature readme file, link to documentation
      on an a separate Web page, ...

How This Was Tested

Tested on a physical platform where this was broken.

Integration Instructions

N/A. On Mu rebase, this commit can be merged with the AdvLogger v5 commit.

@os-d os-d requested review from cfernald, makubacki, kuqin12 and apop5 May 7, 2024 15:45
@codecov-commenter
Copy link

codecov-commenter commented May 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 10.86%. Comparing base (8d7bae0) to head (ea44732).

Additional details and impacted files
@@               Coverage Diff               @@
##           release/202311     #483   +/-   ##
===============================================
  Coverage           10.86%   10.86%           
===============================================
  Files                 142      142           
  Lines               22379    22379           
  Branches             1808     1808           
===============================================
  Hits                 2431     2431           
  Misses              19916    19916           
  Partials               32       32           
Flag Coverage Δ
AdvLoggerPkg 3.71% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@os-d os-d merged commit a9e42d6 into release/202311 May 8, 2024
29 checks passed
@os-d os-d deleted the osde/arm_log_fix branch May 8, 2024 21:40
os-d added a commit that referenced this pull request May 13, 2024
## Description

Fix an error made in the AdvLogger v5 PR (#471). This is the same fix
(but for a different variable name which is why it was mixed on the last
fix up) as #483.

Usage of mHighAddress (and mMaxAddress) will be evaluated as part of
issue #474.

- [x] Impacts functionality?
- **Functionality** - Does the change ultimately impact how firmware
functions?
- Examples: Add a new library, publish a new PPI, update an algorithm,
...
- [ ] Impacts security?
- **Security** - Does the change have a direct security impact on an
application,
    flow, or firmware?
  - Examples: Crypto algorithm change, buffer overflow fix, parameter
    validation improvement, ...
- [ ] Breaking change?
- **Breaking change** - Will anyone consuming this change experience a
break
    in build or boot behavior?
- Examples: Add a new library class, move a module to a different repo,
call
    a function in a new library class in a pre-existing module, ...
- [ ] Includes tests?
  - **Tests** - Does the change include any explicit test code?
  - Examples: Unit tests, integration tests, robot tests, ...
- [ ] Includes documentation?
- **Documentation** - Does the change contain explicit documentation
additions
    outside direct code modifications (and comments)?
- Examples: Update readme file, add feature readme file, link to
documentation
    on an a separate Web page, ...

## How This Was Tested

Tested on Q35, LineParserTestApp was failing because of this.

## Integration Instructions

N/A for a platform. For the next Mu integration, this should be combined
with the Advanced Logger v5 commit
be9a3d2.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants