-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support the platform specific event hooks which can be customized. #469
Support the platform specific event hooks which can be customized. #469
Conversation
Support the platform specific event hooks which can be customized.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/202311 #469 +/- ##
==================================================
- Coverage 12.01% 12.00% -0.02%
==================================================
Files 110 111 +1
Lines 19003 19019 +16
Branches 1735 1735
==================================================
Hits 2283 2283
- Misses 16674 16690 +16
Partials 46 46
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Fixed ci build issue.
@Eathonhsu can you please fill out the Description details? |
@@ -41,11 +41,15 @@ ExitPmAuth ( | |||
|
|||
DEBUG ((DEBUG_INFO, "ExitPmAuth ()- Start\n")); | |||
|
|||
BeforeEndOfDxeEventHook (); // MS_CHANGE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this is in MU_PLUS, we should not need to use MS_CHANGE
tags in this PR.
// | ||
// Since PI1.2.1, we need signal EndOfDxe as ExitPmAuth | ||
// | ||
EfiEventGroupSignal (&gEfiEndOfDxeEventGroupGuid); | ||
|
||
AfterEndOfDxeEventHook (); // MS_CHANGE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In practical cases, we would use these hooks to send platform-specific events to enable the functionality to be activated properly.
Why I choose to use a library instead of send EventGroupSignal
, the reason is that after the platform receives the event callback, the callback function will send its platform-specific events. I'm concerned about potential nesting of muti-events.
Removed the code change tags.
Removed the code chagne tag.
Updated, thanks for the suggestion |
I added the "breaking change" because this would require existing platforms to include a new library instance in their project to allow this to build. |
This PR has been automatically marked as stale because it has not had activity in 60 days. It will be closed if no further activity occurs within 7 days. Thank you for your contributions. |
This pull request has been automatically been closed because it did not have any activity in 60 days and no follow up within 7 days after being marked stale. Thank you for your contributions. |
Description
The current event triggers lack flexibility and cannot be effectively used on some platforms.
flow, or firmware?
validation improvement, ...
in build or boot behavior?
a function in a new library class in a pre-existing module, ...
outside direct code modifications (and comments)?
on an a separate Web page, ...
How This Was Tested
It will not affect the original process, mainly serving as an extension for platform use.
Integration Instructions
Create a new library to be replaced by the platform to expand functionality.