-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MfciDxe: Indicate the MFCI Protocol is produced in the INF #454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
improve comments
github-actions
bot
added
the
impact:non-functional
Does not have a functional impact
label
Mar 23, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/202311 #454 +/- ##
===============================================
Coverage 12.11% 12.11%
===============================================
Files 110 110
Lines 19024 19024
Branches 1735 1735
===============================================
Hits 2305 2305
Misses 16687 16687
Partials 32 32
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
apop5
reviewed
Mar 23, 2024
apop5
approved these changes
Mar 23, 2024
Co-authored-by: Aaron <[email protected]>
remove empty line
makubacki
changed the title
Update MfciDxe.inf
MfciDxe: Indicate the MFCI Protocol is produced in the INF
Mar 25, 2024
makubacki
approved these changes
Mar 25, 2024
makubacki
reviewed
Mar 25, 2024
ProjectMuBot
referenced
this pull request
in microsoft/mu_tiano_platforms
Apr 9, 2024
Introduces 3 new commits in [Common/MU](https://github.com/microsoft/mu_plus.git). <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/microsoft/mu_plus/commit/968f75bcb6231ef5bae68694bad5acc5a11c2421">968f75</a> MfciDxe: Indicate the MFCI Protocol is produced in the INF (<a href="https://github.com/microsoft/mu_plus/pull/454">#454</a>)</li> <li><a href="https://github.com/microsoft/mu_plus/commit/1f3a8e1ebd4ca4f22863d571e8c791926d47bc7c">1f3a8e</a> pip: bump edk2-pytool-library from 0.21.4 to 0.21.5 (<a href="https://github.com/microsoft/mu_plus/pull/456">#456</a>)</li> <li><a href="https://github.com/microsoft/mu_plus/commit/c35b46f62267c1d279450922a3c424eb00cac4c7">c35b46</a> When recovering Pei buffer from hob list, need to fix internal pointe… (<a href="https://github.com/microsoft/mu_plus/pull/457">#457</a>)</li> </ul> </details> Signed-off-by: Project Mu Bot <[email protected]>
kuqin12
referenced
this pull request
in microsoft/mu_tiano_platforms
Apr 9, 2024
Bumps Common/MU from `2023110000.0.3` to `2023110000.0.4` Introduces 3 new commits in [Common/MU](https://github.com/microsoft/mu_plus.git). <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/microsoft/mu_plus/commit/968f75bcb6231ef5bae68694bad5acc5a11c2421">968f75</a> MfciDxe: Indicate the MFCI Protocol is produced in the INF (<a href="https://github.com/microsoft/mu_plus/pull/454">#454</a>)</li> <li><a href="https://github.com/microsoft/mu_plus/commit/1f3a8e1ebd4ca4f22863d571e8c791926d47bc7c">1f3a8e</a> pip: bump edk2-pytool-library from 0.21.4 to 0.21.5 (<a href="https://github.com/microsoft/mu_plus/pull/456">#456</a>)</li> <li><a href="https://github.com/microsoft/mu_plus/commit/c35b46f62267c1d279450922a3c424eb00cac4c7">c35b46</a> When recovering Pei buffer from hob list, need to fix internal pointe… (<a href="https://github.com/microsoft/mu_plus/pull/457">#457</a>)</li> </ul> </details> Signed-off-by: Project Mu Bot <[email protected]> Co-authored-by: kuqin12 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix wrong comment. This module produces gMfciProtocolGuid, and we used this module for the implementation.
flow, or firmware?
validation improvement, ...
in build or boot behavior?
a function in a new library class in a pre-existing module, ...
outside direct code modifications (and comments)?
on an a separate Web page, ...
How This Was Tested
No. Just a comment fix.
Integration Instructions
N/A. Just a comment fix.