Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MfciDxe: Indicate the MFCI Protocol is produced in the INF #454

Merged
merged 3 commits into from
Mar 25, 2024

Conversation

yangrongwei
Copy link
Contributor

@yangrongwei yangrongwei commented Mar 23, 2024

Description

Fix wrong comment. This module produces gMfciProtocolGuid, and we used this module for the implementation.

  • Impacts functionality?
    • Functionality - Does the change ultimately impact how firmware functions?
    • Examples: Add a new library, publish a new PPI, update an algorithm, ...
  • Impacts security?
    • Security - Does the change have a direct security impact on an application,
      flow, or firmware?
    • Examples: Crypto algorithm change, buffer overflow fix, parameter
      validation improvement, ...
  • Breaking change?
    • Breaking change - Will anyone consuming this change experience a break
      in build or boot behavior?
    • Examples: Add a new library class, move a module to a different repo, call
      a function in a new library class in a pre-existing module, ...
  • Includes tests?
    • Tests - Does the change include any explicit test code?
    • Examples: Unit tests, integration tests, robot tests, ...
  • Includes documentation?
    • Documentation - Does the change contain explicit documentation additions
      outside direct code modifications (and comments)?
    • Examples: Update readme file, add feature readme file, link to documentation
      on an a separate Web page, ...

How This Was Tested

No. Just a comment fix.

Integration Instructions

N/A. Just a comment fix.

improve comments
@github-actions github-actions bot added the impact:non-functional Does not have a functional impact label Mar 23, 2024
@codecov-commenter
Copy link

codecov-commenter commented Mar 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 12.11%. Comparing base (cd5daf0) to head (467ffe3).

Additional details and impacted files
@@               Coverage Diff               @@
##           release/202311     #454   +/-   ##
===============================================
  Coverage           12.11%   12.11%           
===============================================
  Files                 110      110           
  Lines               19024    19024           
  Branches             1735     1735           
===============================================
  Hits                 2305     2305           
  Misses              16687    16687           
  Partials               32       32           
Flag Coverage Δ
MfciPkg 38.51% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

MfciPkg/MfciDxe/MfciDxe.inf Outdated Show resolved Hide resolved
yangrongwei and others added 2 commits March 24, 2024 09:12
@makubacki makubacki changed the title Update MfciDxe.inf MfciDxe: Indicate the MFCI Protocol is produced in the INF Mar 25, 2024
@apop5 apop5 merged commit 968f75b into microsoft:release/202311 Mar 25, 2024
33 checks passed
@yangrongwei yangrongwei deleted the patch-2 branch April 5, 2024 13:20
ProjectMuBot referenced this pull request in microsoft/mu_tiano_platforms Apr 9, 2024
Introduces 3 new commits in [Common/MU](https://github.com/microsoft/mu_plus.git).

<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/microsoft/mu_plus/commit/968f75bcb6231ef5bae68694bad5acc5a11c2421">968f75</a> MfciDxe: Indicate the MFCI Protocol is produced in the INF (<a href="https://github.com/microsoft/mu_plus/pull/454">#454</a>)</li>
<li><a href="https://github.com/microsoft/mu_plus/commit/1f3a8e1ebd4ca4f22863d571e8c791926d47bc7c">1f3a8e</a> pip: bump edk2-pytool-library from 0.21.4 to 0.21.5 (<a href="https://github.com/microsoft/mu_plus/pull/456">#456</a>)</li>
<li><a href="https://github.com/microsoft/mu_plus/commit/c35b46f62267c1d279450922a3c424eb00cac4c7">c35b46</a> When recovering Pei buffer from hob list, need to fix internal pointe… (<a href="https://github.com/microsoft/mu_plus/pull/457">#457</a>)</li>
</ul>
</details>

Signed-off-by: Project Mu Bot <[email protected]>
kuqin12 referenced this pull request in microsoft/mu_tiano_platforms Apr 9, 2024
Bumps Common/MU from `2023110000.0.3` to `2023110000.0.4`


Introduces 3 new commits in
[Common/MU](https://github.com/microsoft/mu_plus.git).

<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/microsoft/mu_plus/commit/968f75bcb6231ef5bae68694bad5acc5a11c2421">968f75</a>
MfciDxe: Indicate the MFCI Protocol is produced in the INF (<a
href="https://github.com/microsoft/mu_plus/pull/454">#454</a>)</li>
<li><a
href="https://github.com/microsoft/mu_plus/commit/1f3a8e1ebd4ca4f22863d571e8c791926d47bc7c">1f3a8e</a>
pip: bump edk2-pytool-library from 0.21.4 to 0.21.5 (<a
href="https://github.com/microsoft/mu_plus/pull/456">#456</a>)</li>
<li><a
href="https://github.com/microsoft/mu_plus/commit/c35b46f62267c1d279450922a3c424eb00cac4c7">c35b46</a>
When recovering Pei buffer from hob list, need to fix internal pointe…
(<a href="https://github.com/microsoft/mu_plus/pull/457">#457</a>)</li>
</ul>
</details>

Signed-off-by: Project Mu Bot <[email protected]>
Co-authored-by: kuqin12 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact:non-functional Does not have a functional impact
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants