Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advanced Logger Binary Dump Windows Executable #453

Conversation

VivianNK
Copy link
Contributor

Description

Console app to get Advanced Logger dump.

For each item, place an "x" in between [ and ] if true. Example: [x].
(you can also check items in the GitHub UI)

  • Impacts functionality?
    • Functionality - Does the change ultimately impact how firmware functions?
    • Examples: Add a new library, publish a new PPI, update an algorithm, ...
  • Impacts security?
    • Security - Does the change have a direct security impact on an application,
      flow, or firmware?
    • Examples: Crypto algorithm change, buffer overflow fix, parameter
      validation improvement, ...
  • Breaking change?
    • Breaking change - Will anyone consuming this change experience a break
      in build or boot behavior?
    • Examples: Add a new library class, move a module to a different repo, call
      a function in a new library class in a pre-existing module, ...
  • Includes tests?
    • Tests - Does the change include any explicit test code?
    • Examples: Unit tests, integration tests, robot tests, ...
  • [ x] Includes documentation?
    • Documentation - Does the change contain explicit documentation additions
      outside direct code modifications (and comments)?
    • Examples: Update readme file, add feature readme file, link to documentation
      on an a separate Web page, ...

How This Was Tested

Built and ran on ARM and x64 machines. Verified output was identical to DecodeUefiLog script raw dump.

Integration Instructions

N/A

@github-actions github-actions bot added impact:non-functional Does not have a functional impact type:documentation Improvements or additions to documentation labels Mar 22, 2024
@VivianNK VivianNK requested a review from apop5 March 22, 2024 01:27
@VivianNK VivianNK force-pushed the personal/vnowkakeane/AdvLoggerDumpWinV2 branch from ea711f7 to 68e37e9 Compare March 26, 2024 19:07
@VivianNK VivianNK marked this pull request as ready for review March 26, 2024 19:08
@VivianNK VivianNK force-pushed the personal/vnowkakeane/AdvLoggerDumpWinV2 branch from f80682e to b1ec489 Compare March 27, 2024 20:54
@VivianNK VivianNK self-assigned this Mar 27, 2024
@VivianNK VivianNK requested review from kuqin12 and Flickdm March 27, 2024 21:41
@VivianNK VivianNK force-pushed the personal/vnowkakeane/AdvLoggerDumpWinV2 branch from 99559c2 to 6abc9ec Compare March 28, 2024 23:22
@kuqin12
Copy link
Contributor

kuqin12 commented Apr 8, 2024

This is a dump to get the binary output from advanced logger instead of the parsed version, correct? If so, can you please update the PR title and description to make that clearer?

@VivianNK VivianNK changed the title Advanced Logger Dump Windows Executable Advanced Logger Binary Dump Windows Executable Apr 8, 2024
@VivianNK VivianNK force-pushed the personal/vnowkakeane/AdvLoggerDumpWinV2 branch from 6abc9ec to 44904ad Compare April 9, 2024 19:35
@VivianNK VivianNK enabled auto-merge (squash) April 9, 2024 19:36
@VivianNK VivianNK merged commit 2d0faca into microsoft:release/202311 Apr 9, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact:non-functional Does not have a functional impact type:documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants