SecureBootRecovery: Add Logic to detect 2023 Windows Production CA #432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flickdm
changed the title
apop5
reviewed
Feb 6, 2024
apop5
reviewed
Feb 6, 2024
apop5
approved these changes
Feb 6, 2024
kenlautner
reviewed
Feb 6, 2024
kenlautner
reviewed
Feb 6, 2024
kenlautner
reviewed
Feb 6, 2024
kenlautner
approved these changes
Feb 6, 2024
makubacki
reviewed
Feb 6, 2024
makubacki
reviewed
Feb 6, 2024
makubacki
reviewed
Feb 6, 2024
makubacki
reviewed
Feb 6, 2024
makubacki
reviewed
Feb 6, 2024
makubacki
reviewed
Feb 6, 2024
makubacki
reviewed
Feb 6, 2024
makubacki
approved these changes
Feb 6, 2024
Flickdm
force-pushed
the
feature/MsApplicationPkg/SecureBootRecovery
branch
2 times, most recently
from
9b65ea9 to
ac6f817
Compare
makubacki
reviewed
Feb 7, 2024
Flickdm
force-pushed
the
feature/MsApplicationPkg/SecureBootRecovery
branch
from
ac6f817 to
1bbf2af
Compare
github-actions
bot
added
the
language:python
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/202302 #432 +/- ##
===============================================
Coverage 12.13% 12.13%
===============================================
Files 110 110
Lines 19022 19022
Branches 1363 1363
===============================================
Hits 2308 2308
Misses 16697 16697
Partials 17 17
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
This PR has been automatically marked as stale because it has not had activity in 60 days. It will be closed if no further activity occurs within 7 days. Thank you for your contributions. |
|
This pull request has been automatically been closed because it did not have any activity in 60 days and no follow up within 7 days after being marked stale. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change adds the ability for the SecureBootRecovery application to detect the existence of the 2023 Windows Production CA and prevent updating the DB if found.
How This Was Tested
This application was self signed on a production system using custom Secure Boot keystore.
This was tested with:
No Secure boot Certificates
Only the 2011 Certificates
All Certificates (2011 and 2023)
Integration Instructions
N/A