Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed references to openssllib and it's associated libraries #410

Merged

Conversation

kenlautner
Copy link
Contributor

@kenlautner kenlautner commented Jan 19, 2024

Description

There are some references to BaseCryptLib and Openssl in package dsc files. In MU_BASECORE Openssl and its BaseCryptLib implementations were removed so we need to update to using the NULL lib.

  • Impacts functionality?
    • Functionality - Does the change ultimately impact how firmware functions?
    • Examples: Add a new library, publish a new PPI, update an algorithm, ...
  • Impacts security?
    • Security - Does the change have a direct security impact on an application,
      flow, or firmware?
    • Examples: Crypto algorithm change, buffer overflow fix, parameter
      validation improvement, ...
  • Breaking change?
    • Breaking change - Will anyone consuming this change experience a break
      in build or boot behavior?
    • Examples: Add a new library class, move a module to a different repo, call
      a function in a new library class in a pre-existing module, ...
  • Includes tests?
    • Tests - Does the change include any explicit test code?
    • Examples: Unit tests, integration tests, robot tests, ...
  • Includes documentation?
    • Documentation - Does the change contain explicit documentation additions
      outside direct code modifications (and comments)?
    • Examples: Update readme file, add feature readme file, link to documentation
      on an a separate Web page, ...

How This Was Tested

Tested with CI

Integration Instructions

N/A

@github-actions github-actions bot added the impact:non-functional Does not have a functional impact label Jan 19, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jan 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d269a99) 12.13% compared to head (9954b3a) 12.13%.

Additional details and impacted files
@@               Coverage Diff               @@
##           release/202302     #410   +/-   ##
===============================================
  Coverage           12.13%   12.13%           
===============================================
  Files                 110      110           
  Lines               19022    19022           
  Branches             1363     1363           
===============================================
  Hits                 2308     2308           
  Misses              16697    16697           
  Partials               17       17           
Flag Coverage Δ
MfciPkg 38.25% <ø> (ø)
MsCorePkg 1.43% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kenlautner kenlautner merged commit c56b9d8 into release/202302 Jan 19, 2024
31 checks passed
@kenlautner kenlautner deleted the personal/klautner/Update_crypto_dependencies branch January 19, 2024 17:22
ProjectMuBot referenced this pull request in microsoft/mu_tiano_platforms Jan 21, 2024
Introduces 8 new commits in [Common/MU](https://github.com/microsoft/mu_plus.git).

<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/microsoft/mu_plus/commit/ca8ab999088f2df2e59ef79bdd8eeecbe8ac0051">ca8ab9</a> .git-blame-ignore-revs: Ignore Line Ending and Uncrustify only commits (<a href="https://github.com/microsoft/mu_plus/pull/404">#404</a>)</li>
<li><a href="https://github.com/microsoft/mu_plus/commit/69d1c094ca61f6d12e8c8e172b07576120e6d259">69d1c0</a> Fixing uninitialized variable build error (<a href="https://github.com/microsoft/mu_plus/pull/406">#406</a>)</li>
<li><a href="https://github.com/microsoft/mu_plus/commit/de34c204964c15253b49725c8a0420951c0f20ee">de34c2</a> pip: bump edk2-pytool-library from 0.19.8 to 0.19.9 (<a href="https://github.com/microsoft/mu_plus/pull/407">#407</a>)</li>
<li><a href="https://github.com/microsoft/mu_plus/commit/d269a99999db22f015c61acf8d610e7078b64b3e">d269a9</a> Wrap advanced logger buffer cursor when the logging area is full (<a href="https://github.com/microsoft/mu_plus/pull/408">#408</a>)</li>
<li><a href="https://github.com/microsoft/mu_plus/commit/c56b9d8809d511e3c7674c18fab09de9915e1fad">c56b9d</a> Removed references to openssllib and it's associated libraries (<a href="https://github.com/microsoft/mu_plus/pull/410">#410</a>)</li>
<li><a href="https://github.com/microsoft/mu_plus/commit/f434085d775f0963c5f62e0517bace8ca70b5529">f43408</a> Repo File Sync: Add Cargo features to Makefile.toml (<a href="https://github.com/microsoft/mu_plus/pull/409">#409</a>)</li>
<li><a href="https://github.com/microsoft/mu_plus/commit/a6a9f878693a1ab8fcbb0b06576b4acb149ecfd9">a6a9f8</a> AdvLoggerPkg: 64-bit SEC & PEI C Code changes</li>
<li><a href="https://github.com/microsoft/mu_plus/commit/d19b1ee73f14ed1f4f921daa3ae7116c92acb811">d19b1e</a> AdvLoggerPkg/SecDebugAgent: Update for 64-bit</li>
</ul>
</details>

Signed-off-by: Project Mu Bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact:non-functional Does not have a functional impact
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants