Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MsGraphicsPkg/SimpleUIToolKit: Move array bounds check before access #386

Merged
merged 1 commit into from
Dec 13, 2023
Merged

MsGraphicsPkg/SimpleUIToolKit: Move array bounds check before access #386

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion MsGraphicsPkg/Library/SimpleUIToolKit/ListBox.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -946,7 +946,7 @@ Ctor (

// Iterate through cell list and compute bounding rectangle, checkbox bounding rectangle (optional) and string bitmap rectangle.
//
for (Index = 0; CellData[Index].CellText != NULL && Index < this->m_NumberOfCells; Index++) {
for (Index = 0; Index < this->m_NumberOfCells && CellData[Index].CellText != NULL; Index++) {
this->m_pCells[Index].OriginalOrder = Index;
this->m_pCells[Index].pCellText = AllocateCopyPool (StrSize (CellData[Index].CellText), CellData[Index].CellText);
this->m_pCells[Index].CheckboxSelected = CellData[Index].CheckBoxSelected;
Expand Down