Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inspect mLoggerInfo before accessing in the event callback #345

Merged
merged 6 commits into from
Nov 15, 2023
Merged

Inspect mLoggerInfo before accessing in the event callback #345

Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
bf5db50
check for null pointer
kuqin12 Oct 31, 2023
05b2f0c
Merge branch 'release/202302' into core_adv_logger
kuqin12 Oct 31, 2023
f5f21fe
Update AdvLoggerPkg/Library/AdvancedLoggerLib/DxeCore/AdvancedLoggerL…
kuqin12 Nov 3, 2023
1892ea7
Merge branch 'release/202302' into core_adv_logger
kuqin12 Nov 3, 2023
6cd5ee2
Merge branch 'release/202302' into core_adv_logger
kuqin12 Nov 15, 2023
87dafb9
uncrustify
kuqin12 Nov 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions AdvLoggerPkg/Library/AdvancedLoggerLib/DxeCore/AdvancedLoggerLib.c
View file
Open in desktop
kuqin12 marked this conversation as resolved.
Show resolved Hide resolved
Original file line number Diff line number Diff line change
Expand Up @@ -189,11 +189,13 @@ OnRealTimeClockArchNotification (

SystemTable->BootServices->CloseEvent (Event);

Status = SystemTable->RuntimeServices->GetTime ((EFI_TIME *)&mLoggerInfo->Time, NULL);
if (EFI_ERROR (Status)) {
DEBUG ((DEBUG_INFO, "%a: error getting real time. Code=%r\n", __FUNCTION__, Status));
} else {
mLoggerInfo->TicksAtTime = GetPerformanceCounter ();
if (mLoggerInfo != NULL) {
Status = SystemTable->RuntimeServices->GetTime ((EFI_TIME *)&mLoggerInfo->Time, NULL);
if (EFI_ERROR (Status)) {
DEBUG ((DEBUG_INFO, "%a: error getting real time. Code=%r\n", __FUNCTION__, Status));
kuqin12 marked this conversation as resolved.
Show resolved Hide resolved
} else {
mLoggerInfo->TicksAtTime = GetPerformanceCounter ();
}
}

return;
Expand Down