Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update HelloWorldRustDxe to permit compiling for unit tests #341

Merged
merged 1 commit into from
Oct 25, 2023
Merged

Update HelloWorldRustDxe to permit compiling for unit tests #341

merged 1 commit into from
Oct 25, 2023

Conversation

joschock
Copy link
Contributor

Description

Update HelloWorldRustDxe to allow compiling tests.

  • Impacts functionality?
  • Impacts security?
  • Breaking change?
  • Includes tests?
    • adds a sample unit test for the HelloWorldRustDxe driver.
  • Includes documentation?

How This Was Tested

Cargo test executes sample unit test as expected.
Build for UEFI target and execution QEMU work as expected.

Integration Instructions

N/A

@github-actions github-actions bot added impact:non-functional Does not have a functional impact impact:testing Affects testing labels Oct 21, 2023
@joschock joschock force-pushed the personal/joschock/enable_unit_testing_hello_world branch from 1668abb to 7fd72b5 Compare October 21, 2023 23:46
@makubacki makubacki requested a review from apop5 October 23, 2023 17:39
@makubacki makubacki merged commit b93bb28 into microsoft:release/202302 Oct 25, 2023
31 checks passed
ProjectMuBot referenced this pull request in microsoft/mu_tiano_platforms Oct 27, 2023
@ProjectMuBot
Bumps Common/MU from 2023020002.1.0 to 2023020003.0.0
725b289 
Introduces 3 new commits in [Common/MU](https://github.com/microsoft/mu_plus.git).

<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/microsoft/mu_plus/commit/b93bb28e1b39004fc2e3a194a131aacf95c774ae">b93bb2</a> Update HelloWorldRustDxe to permit compiling for unit tests (<a href="https://github.com/microsoft/mu_plus/pull/341">#341</a>)</li>
<li><a href="https://github.com/microsoft/mu_plus/commit/0c488d7079b9f8ee6039ebad221b7cb720d0662d">0c488d</a> Repo File Sync: Include Rust Env Exclusions in CodeQL Workflow (<a href="https://github.com/microsoft/mu_plus/pull/344">#344</a>)</li>
<li><a href="https://github.com/microsoft/mu_plus/commit/dc3ab8ba5e3c5403ae6644f68d0474ba0d1b190c">dc3ab8</a> Add PCD to allow device exclusions for UsbHidDxe (<a href="https://github.com/microsoft/mu_plus/pull/340">#340</a>)</li>
</ul>
</details>

Signed-off-by: Project Mu Bot <[email protected]>
@ProjectMuBot ProjectMuBot mentioned this pull request Oct 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apop5 apop5 apop5 approved these changes

@makubacki makubacki makubacki approved these changes

Assignees
No one assigned
Labels
impact:non-functional Does not have a functional impact impact:testing Affects testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joschock @makubacki @apop5