Add PCD to allow device exclusions for UsbHidDxe #340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
impact:breaking-change
makubacki
approved these changes
Oct 20, 2023
apop5
reviewed
Oct 23, 2023
apop5
approved these changes
Oct 23, 2023
auto-merge was automatically disabled
October 25, 2023 19:14
Head branch was pushed to by a user without write access
makubacki
force-pushed
the
personal/joschock/add_usb_hid_dxe_exclusion_pcd
branch
from
c23dc38 to
5ac7a37
Compare
ProjectMuBot
referenced
this pull request
in microsoft/mu_tiano_platforms
Oct 27, 2023
Introduces 3 new commits in [Common/MU](https://github.com/microsoft/mu_plus.git). <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/microsoft/mu_plus/commit/b93bb28e1b39004fc2e3a194a131aacf95c774ae">b93bb2</a> Update HelloWorldRustDxe to permit compiling for unit tests (<a href="https://github.com/microsoft/mu_plus/pull/341">#341</a>)</li> <li><a href="https://github.com/microsoft/mu_plus/commit/0c488d7079b9f8ee6039ebad221b7cb720d0662d">0c488d</a> Repo File Sync: Include Rust Env Exclusions in CodeQL Workflow (<a href="https://github.com/microsoft/mu_plus/pull/344">#344</a>)</li> <li><a href="https://github.com/microsoft/mu_plus/commit/dc3ab8ba5e3c5403ae6644f68d0474ba0d1b190c">dc3ab8</a> Add PCD to allow device exclusions for UsbHidDxe (<a href="https://github.com/microsoft/mu_plus/pull/340">#340</a>)</li> </ul> </details> Signed-off-by: Project Mu Bot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a PCD for configuring device exclusions for UsbHidDxe. Prior to this change, the UsbHidDxe driver included logic to exclude keyboard devices from being handled by HID, due to other parts of the stack not being fully implemented yet. This removes that code and replaces it with a PCD list that the platform integrator can use to disable particular devices as desired for the platform.
Previously keyboard exclusion was hard-coded; to replicate this behavior platforms will need to add a PCD specification in the DSC files to exclude keyboards. See Integration Instructions below for more details.
How This Was Tested
Verified with functional testing of several different exclusions in Qemu Q35.
Integration Instructions
To replicate existing behavior, platforms will need to add PCD specification to the DSC like the following to exclude USB keyboards: