DfciPkg/UnitTests/pip-requirements.txt: Remove pytool-library; bump robot framework #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…botframework - Removes edk2-pytool-library since it has a very old version and the module can be picked up from (1) the main repo pip-requirements.txt or (2) the edk2-pytool-extensions dependency. - Updates robotframework pip module version since it also now very old. Signed-off-by: Michael Kubacki <[email protected]>
|
@spbrogan - I only found this section in the documentation that is related to this change - DfciPkg/UnitTests/DfciTests - Setting up the HOST system. It only references that the |
|
@mikeytdisco, this is something I found when going through the pip modules pulled down in our pipelines. I don't have an environment set up to run the tests. Have you been running them recently? Could you try including this change the next time you run the robot tests? |
apop5
approved these changes
Dec 15, 2022
|
Comment to bump as a reminder |
1 task
|
Moved to issue in mu_feature_dfci - microsoft/mu_feature_dfci#46 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes edk2-pytool-library since it has a very old version and
the module can be picked up from (1) the main repo
pip-requirements.txt or (2) the edk2-pytool-extensions dependency.
Updates robotframework pip module version since it also now very old.
Breaking change?
No - Should not be breaking for the reasons mentioned in the description.
How This Was Tested
Todo
Integration Instructions
N/A
Signed-off-by: Michael Kubacki [email protected]