Skip to content

Commit

Permalink
Split MemoryProtectionTestApp to DXE and SMM Versions (#379)
Browse files Browse the repository at this point in the history
## Description

MemoryProtectionTestApp was written before Project Mu supported an ARM
platform and Standalone MM. The test app generates the test cases for
both the SMM and DXE environments. The SMM tests will report failure for
Arm platforms and platforms using Standalone MM, so this update
separates the test app into SMM and DXE versions.

The SMM version will still require a driver to handle the SMI calls. To
reduce confusing naming, MemoryProtectionTestSmm (the driver supporting
SMM memory protection testing) has been renamed to
SmmMemoryProtectionTestDriver.

- [x] Impacts functionality?
- **Functionality** - Does the change ultimately impact how firmware
functions?
- Examples: Add a new library, publish a new PPI, update an algorithm,
...
- [ ] Impacts security?
- **Security** - Does the change have a direct security impact on an
application,
    flow, or firmware?
  - Examples: Crypto algorithm change, buffer overflow fix, parameter
    validation improvement, ...
- [ ] Breaking change?
- **Breaking change** - Will anyone consuming this change experience a
break
    in build or boot behavior?
- Examples: Add a new library class, move a module to a different repo,
call
    a function in a new library class in a pre-existing module, ...
- [ ] Includes tests?
  - **Tests** - Does the change include any explicit test code?
  - Examples: Unit tests, integration tests, robot tests, ...
- [ ] Includes documentation?
- **Documentation** - Does the change contain explicit documentation
additions
    outside direct code modifications (and comments)?
- Examples: Update readme file, add feature readme file, link to
documentation
    on an a separate Web page, ...

## How This Was Tested

SMM test was checked on a physical x86 platform. The DXE test was
checked on Q35 and SBSA

## Integration Instructions

Instances of

`

UefiTestingPkg/FunctionalSystemTests/MemoryProtectionTest/App/MemoryProtectionTestApp.inf
`

will need to be updated to


`UefiTestingPkg/FunctionalSystemTests/MemoryProtectionTest/App/SmmMemoryProtectionTestApp.inf

UefiTestingPkg/FunctionalSystemTests/MemoryProtectionTest/App/DxeMemoryProtectionTestApp.inf
`

And instances of

`

UefiTestingPkg/FunctionalSystemTests/MemoryProtectionTest/Smm/MemoryProtectionTestSmm.inf
`

will need to be updated to

`

UefiTestingPkg/FunctionalSystemTests/MemoryProtectionTest/Driver/SmmMemoryProtectionTestDriver.inf
`
  • Loading branch information
TaylorBeebe authored Dec 8, 2023
1 parent 0e360b0 commit f535499
Show file tree
Hide file tree
Showing 7 changed files with 3,432 additions and 2 deletions.
Loading

0 comments on commit f535499

Please sign in to comment.