Skip to content

Commit

Permalink
Bugfix: Fix Off by One Error When Creating X64 PlatformInfo.dat (#317)
Browse files Browse the repository at this point in the history
## Description

AsciiSPrint() returns the string index non-inclusive of the NULL
terminator, so adding 1 to the returned string index causes a NULL byte
to be at the end of the PlatformInfo.dat file which can cause a parsing
error when interpreted in .csv format in python.

- [x] Impacts functionality?
- **Functionality** - Does the change ultimately impact how firmware
functions?
- Examples: Add a new library, publish a new PPI, update an algorithm,
...
- [ ] Impacts security?
- **Security** - Does the change have a direct security impact on an
application,
    flow, or firmware?
  - Examples: Crypto algorithm change, buffer overflow fix, parameter
    validation improvement, ...
- [ ] Breaking change?
- **Breaking change** - Will anyone consuming this change experience a
break
    in build or boot behavior?
- Examples: Add a new library class, move a module to a different repo,
call
    a function in a new library class in a pre-existing module, ...
- [ ] Includes tests?
  - **Tests** - Does the change include any explicit test code?
  - Examples: Unit tests, integration tests, robot tests, ...
- [ ] Includes documentation?
- **Documentation** - Does the change contain explicit documentation
additions
    outside direct code modifications (and comments)?
- Examples: Update readme file, add feature readme file, link to
documentation
    on an a separate Web page, ...

## How This Was Tested

Tested on Q35

## Integration Instructions

N/A
  • Loading branch information
TaylorBeebe authored Sep 26, 2023
1 parent 506de63 commit ac481a4
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -777,5 +777,5 @@ DumpPlatforminfo (
CalculateMaximumSupportAddressBits ()
);

WriteBufferToFile (L"PlatformInfo", TempString, StringIndex + 1);
WriteBufferToFile (L"PlatformInfo", TempString, StringIndex);
}

0 comments on commit ac481a4

Please sign in to comment.