HidPkg/UsbHidDxe: Continue on failure to get descriptor

In case a HID device fails to return a HID descriptor, this change will return the error status from UsbHidDriverBindingStart() rather than assert to match previous behavior from HID drivers. The HID IO protocol will not be installed on these devices. Signed-off-by: Michael Kubacki <[email protected]>
microsoft · Oct 17, 2023 · 11bf6a6 · 11bf6a6
1 parent 1824154
commit 11bf6a6
Showing 1 changed file with 0 additions and 2 deletions.
diff --git a/HidPkg/UsbHidDxe/UsbHidDxe.c b/HidPkg/UsbHidDxe/UsbHidDxe.c
@@ -723,7 +723,6 @@ ReadDescriptors (
 
   Status = UsbGetFullHidDescriptor (UsbHidDevice->UsbIo, UsbHidDevice->InterfaceDescriptor.InterfaceNumber, &UsbHidDevice->HidDescriptor);
   if (EFI_ERROR (Status)) {
-    ASSERT_EFI_ERROR (Status);
     goto ErrorExit;
   }
 
@@ -895,7 +894,6 @@ UsbHidDriverBindingStart (
 
   Status = ReadDescriptors (UsbHidDevice);
   if (EFI_ERROR (Status)) {
-    ASSERT_EFI_ERROR (Status);
     goto ErrorExit;
   }