Skip to content

Commit

Permalink
Address review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
srilathasridharan committed Nov 29, 2023
1 parent 6590088 commit 0872235
Show file tree
Hide file tree
Showing 5 changed files with 6 additions and 20 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent

#include <Base.h>
#include <Uefi.h>
#include <Library/BaseMemoryLib.h>
#include <Library/DebugLib.h>
#include <Library/UefiBootServicesTableLib.h>
#include <Protocol/GraphicsOutput.h>
#include <Library/MemoryAllocationLib.h>
#include <Library/FrameBufferMemDrawLib.h>
#include <Library/FrameBufferBltLib.h>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,13 +8,10 @@ SPDX-License-Identifier: BSD-2-Clause-Patent

#include <Base.h>
#include <Uefi.h>
#include <Library/BaseMemoryLib.h>
#include <Library/DebugLib.h>
#include <Library/UefiBootServicesTableLib.h>
#include <Protocol/GraphicsOutput.h>
#include <Library/MemoryAllocationLib.h>
#include <Library/FrameBufferMemDrawLib.h>
#include <Library/FrameBufferBltLib.h>

STATIC EFI_GRAPHICS_OUTPUT_PROTOCOL *mGraphicsOutput = NULL;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

[Defines]
INF_VERSION = 0x00010017
BASE_NAME = FrameBufferMemDrawLib
BASE_NAME = FrameBufferMemDrawLibDxe
FILE_GUID = 75561EAF-4537-4FA8-B65B-40E652602A8B
VERSION_STRING = 1.0
MODULE_TYPE = DXE_DRIVER
Expand All @@ -21,6 +21,7 @@
DebugLib
FrameBufferBltLib
MemoryAllocationLib
UefiBootServicesTableLib

[Packages]
MdePkg/MdePkg.dec
Expand All @@ -30,9 +31,7 @@
[Sources]
FrameBufferMemDrawLib.c
FrameBufferMemDrawLibDxe.c

[LibraryClasses]
UefiBootServicesTableLib
FrameBufferMemDrawLib.h

[Protocols]
gEfiGraphicsOutputProtocolGuid ## SOMETIMES_CONSUMES
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

[Defines]
INF_VERSION = 0x00010017
BASE_NAME = FrameBufferMemDrawLib
BASE_NAME = FrameBufferMemDrawLibPei
FILE_GUID = 23E999E3-B231-4076-8791-DA5151BB3DC4
VERSION_STRING = 1.0
MODULE_TYPE = PEIM
Expand All @@ -19,25 +19,20 @@
DebugLib
FrameBufferBltLib
MemoryAllocationLib
PeiServicesLib

[Packages]
MdePkg/MdePkg.dec
MdeModulePkg/MdeModulePkg.dec
MsGraphicsPkg/MsGraphicsPkg.dec

##
## PEIM Version
##
[Sources]
FrameBufferMemDrawLib.c
FrameBufferMemDrawLibPeim.c

[LibraryClasses]
PeiServicesLib
FrameBufferMemDrawLib.h

[Ppis]
gEfiPeiGraphicsPpiGuid

[Depex]
gEfiPeiGraphicsPpiGuid

Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,6 @@ SPDX-License-Identifier: BSD-2-Clause-Patent

#include <Ppi/Graphics.h>

#include <Protocol/GraphicsOutput.h>

#include <Library/DebugLib.h>
#include <Library/PeiServicesLib.h>

Expand Down

0 comments on commit 0872235

Please sign in to comment.