-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor ProviderValueAsAscii() #48
Merged
makubacki
merged 11 commits into
microsoft:main
from
wenbhou:personal/wenbhou/refactor_ProviderValueAsAscii
Mar 10, 2023
Merged
Refactor ProviderValueAsAscii() #48
makubacki
merged 11 commits into
microsoft:main
from
wenbhou:personal/wenbhou/refactor_ProviderValueAsAscii
Mar 10, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
impact:non-functional
Does not have a functional impact
label
Mar 7, 2023
github-actions
bot
removed
the
impact:non-functional
Does not have a functional impact
label
Mar 9, 2023
makubacki
force-pushed
the
personal/wenbhou/refactor_ProviderValueAsAscii
branch
from
March 9, 2023 19:25
fa792bf
to
10ab4d9
Compare
apop5
approved these changes
Mar 9, 2023
makubacki
reviewed
Mar 9, 2023
makubacki
reviewed
Mar 9, 2023
makubacki
reviewed
Mar 9, 2023
makubacki
approved these changes
Mar 9, 2023
Co-authored-by: Aaron <[email protected]>
Co-authored-by: Aaron <[email protected]>
Co-authored-by: Aaron <[email protected]>
Co-authored-by: Aaron <[email protected]>
@wenbhou, it looks like there's just uncrustify errors. Other than those, are you ready for this to be merged? |
wenbhou
requested review from
makubacki
and removed request for
TaylorBeebe and
kuqin12
March 10, 2023 14:27
makubacki
reviewed
Mar 10, 2023
makubacki
reviewed
Mar 10, 2023
makubacki
reviewed
Mar 10, 2023
Co-authored-by: Michael Kubacki <[email protected]>
Co-authored-by: Michael Kubacki <[email protected]>
Co-authored-by: Michael Kubacki <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactor ProviderValueAsAscii() and remove following macros to make it can allocate buffer with right size for each setting.
Fix #43
flow, or firmware?
validation improvement, ...
in build or boot behavior?
a function in a new library class in a pre-existing module, ...
outside direct code modifications (and comments)?
on an a separate Web page, ...
How This Was Tested
Tested with SEMM tool. No regression seen.
Integration Instructions
N/A