New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DfciPkg/DfciTests: remove silicon-specific test #237

Merged

makubacki merged 1 commit into microsoft:main from cmruffin:personal/v-chruffin/remove-smt-test

Aug 6, 2024

Contributor

cmruffin commented Jul 26, 2024 •

edited by makubacki

Loading

Description

Current base tests DCFI_IntuneSettings use the Dfci3.ProcessorSMT.Enable option for testing DFCI V3 features but this is a silicon specific option that fails on Microsoft AARCH64 platforms as it is not present. Recommend the base tests avoid use of silicon-specific features as these tests will not broadly pass.

How This Was Tested

DFCI testing on AARCH64 platform.

Integration Instructions

NA

Fixes #235

github-actions bot added the impact:non-functional label

Contributor Author

cmruffin commented Jul 26, 2024

@Flickdm can you help with the review?

Flickdm approved these changes

View reviewed changes

Flickdm requested a review from makubacki

August 6, 2024 06:44

makubacki approved these changes

View reviewed changes


          DfciPkg/DfciTests: remove silicon-specific test

54f0ad1

makubacki force-pushed the personal/v-chruffin/remove-smt-test branch from 2f41104 to 54f0ad1 Compare

August 6, 2024 14:19

makubacki enabled auto-merge (squash)

August 6, 2024 14:20

makubacki merged commit da68e5d into microsoft:main

13 checks passed

ProjectMuBot referenced this pull request in microsoft/mu_tiano_platforms


          Bumps Features/DFCI from 4.0.6 to 4.0.8

4d1ba47

Introduces 16 new commits in [Features/DFCI](https://github.com/microsoft/mu_feature_dfci).

<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/microsoft/mu_feature_dfci/commit/28440ba9877f20968f4517bc3ae0d8573b011d26">28440b</a> pip: bump regex from 2024.5.10 to 2024.5.15 (<a href="https://github.com/microsoft/mu_feature_dfci/pull/221">#221</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_dfci/commit/cdb8548eee66bf1e1d0a3c90d3e30b417db17691">cdb854</a> Repo File Sync: synced file(s) with microsoft/mu_devops (<a href="https://github.com/microsoft/mu_feature_dfci/pull/222">#222</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_dfci/commit/66b7d0d855b950e7b7732f0b70e4c194f3e2b311">66b7d0</a> pip: bump edk2-pytool-extensions from 0.27.4 to 0.27.5 (<a href="https://github.com/microsoft/mu_feature_dfci/pull/223">#223</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_dfci/commit/3db208cd25cb50ad3a6cfc0e1e1f94e779e23f40">3db208</a> pip: bump edk2-pytool-library from 0.21.5 to 0.21.6 (<a href="https://github.com/microsoft/mu_feature_dfci/pull/224">#224</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_dfci/commit/3e7a25bb3c23580755d1395089062688a1dbf90a">3e7a25</a> pip: bump edk2-pytool-library from 0.21.6 to 0.21.7 (<a href="https://github.com/microsoft/mu_feature_dfci/pull/226">#226</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_dfci/commit/a620f74329942817f697619e87276d5c4ac9dc2c">a620f7</a> pip: bump edk2-pytool-extensions from 0.27.5 to 0.27.6 (<a href="https://github.com/microsoft/mu_feature_dfci/pull/225">#225</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_dfci/commit/93f6017fe2d0d3bc414fd86ac9abb2a292cb395f">93f601</a> pip: bump edk2-pytool-library from 0.21.7 to 0.21.8 (<a href="https://github.com/microsoft/mu_feature_dfci/pull/227">#227</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_dfci/commit/80a384f3234e5d39e28ae66e0371313b10728710">80a384</a> Repo File Sync: synced file(s) with microsoft/mu_devops (<a href="https://github.com/microsoft/mu_feature_dfci/pull/228">#228</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_dfci/commit/e60ba641349d95c9563b9f5eeb9f6ca2082e977c">e60ba6</a> GitHub Action: Bump robinraju/release-downloader from 1.10 to 1.11 (<a href="https://github.com/microsoft/mu_feature_dfci/pull/229">#229</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_dfci/commit/98dabf9585976b3e62fdd942afef5567039a4c4f">98dabf</a> pip: bump edk2-pytool-extensions from 0.27.6 to 0.27.9 (<a href="https://github.com/microsoft/mu_feature_dfci/pull/231">#231</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_dfci/commit/981a67c31e0334583b60ab08a3dd252c11e59432">981a67</a> pip: bump edk2-pytool-extensions from 0.27.9 to 0.27.10 (<a href="https://github.com/microsoft/mu_feature_dfci/pull/232">#232</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_dfci/commit/c381d64eb91b0038222759459775742f205fa54c">c381d6</a> pip: bump regex from 2024.5.15 to 2024.7.24 (<a href="https://github.com/microsoft/mu_feature_dfci/pull/239">#239</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_dfci/commit/0262f7d1ed8f74b817cb0c7655e2c2787f6980c6">0262f7</a> pip: bump edk2-pytool-library from 0.21.8 to 0.21.9 (<a href="https://github.com/microsoft/mu_feature_dfci/pull/238">#238</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_dfci/commit/2dd22c3b6f9777e911098c5fd2219b1d97eaea53">2dd22c</a> DfciPkg/DfciSettings.h: Add new DFCI settings (<a href="https://github.com/microsoft/mu_feature_dfci/pull/240">#240</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_dfci/commit/514e1526537f00134512fda810e60abb648a8959">514e15</a> DfciPkg/DfciTests: fix refresh server pip failure (<a href="https://github.com/microsoft/mu_feature_dfci/pull/236">#236</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_dfci/commit/da68e5dab1b1fc5fbdb58a6d45c6c12147047bb6">da68e5</a> DfciPkg/DfciTests: remove silicon-specific test (<a href="https://github.com/microsoft/mu_feature_dfci/pull/237">#237</a>)</li>
</ul>
</details>

Signed-off-by: Project Mu Bot <[email protected]>

ProjectMuBot mentioned this pull request

Bump Features/DFCI from 4.0.6 to 4.0.8 microsoft/mu_tiano_platforms#1009

Merged

apop5 referenced this pull request in microsoft/mu_tiano_platforms


          Bump Features/DFCI from 4.0.6 to 4.0.8 (#1009)

c0d6ebd

Bumps Features/DFCI from `4.0.6` to `4.0.8`


Introduces 16 new commits in
[Features/DFCI](https://github.com/microsoft/mu_feature_dfci).

<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/microsoft/mu_feature_dfci/commit/28440ba9877f20968f4517bc3ae0d8573b011d26">28440b</a>
pip: bump regex from 2024.5.10 to 2024.5.15 (<a
href="https://github.com/microsoft/mu_feature_dfci/pull/221">#221</a>)</li>
<li><a
href="https://github.com/microsoft/mu_feature_dfci/commit/cdb8548eee66bf1e1d0a3c90d3e30b417db17691">cdb854</a>
Repo File Sync: synced file(s) with microsoft/mu_devops (<a
href="https://github.com/microsoft/mu_feature_dfci/pull/222">#222</a>)</li>
<li><a
href="https://github.com/microsoft/mu_feature_dfci/commit/66b7d0d855b950e7b7732f0b70e4c194f3e2b311">66b7d0</a>
pip: bump edk2-pytool-extensions from 0.27.4 to 0.27.5 (<a
href="https://github.com/microsoft/mu_feature_dfci/pull/223">#223</a>)</li>
<li><a
href="https://github.com/microsoft/mu_feature_dfci/commit/3db208cd25cb50ad3a6cfc0e1e1f94e779e23f40">3db208</a>
pip: bump edk2-pytool-library from 0.21.5 to 0.21.6 (<a
href="https://github.com/microsoft/mu_feature_dfci/pull/224">#224</a>)</li>
<li><a
href="https://github.com/microsoft/mu_feature_dfci/commit/3e7a25bb3c23580755d1395089062688a1dbf90a">3e7a25</a>
pip: bump edk2-pytool-library from 0.21.6 to 0.21.7 (<a
href="https://github.com/microsoft/mu_feature_dfci/pull/226">#226</a>)</li>
<li><a
href="https://github.com/microsoft/mu_feature_dfci/commit/a620f74329942817f697619e87276d5c4ac9dc2c">a620f7</a>
pip: bump edk2-pytool-extensions from 0.27.5 to 0.27.6 (<a
href="https://github.com/microsoft/mu_feature_dfci/pull/225">#225</a>)</li>
<li><a
href="https://github.com/microsoft/mu_feature_dfci/commit/93f6017fe2d0d3bc414fd86ac9abb2a292cb395f">93f601</a>
pip: bump edk2-pytool-library from 0.21.7 to 0.21.8 (<a
href="https://github.com/microsoft/mu_feature_dfci/pull/227">#227</a>)</li>
<li><a
href="https://github.com/microsoft/mu_feature_dfci/commit/80a384f3234e5d39e28ae66e0371313b10728710">80a384</a>
Repo File Sync: synced file(s) with microsoft/mu_devops (<a
href="https://github.com/microsoft/mu_feature_dfci/pull/228">#228</a>)</li>
<li><a
href="https://github.com/microsoft/mu_feature_dfci/commit/e60ba641349d95c9563b9f5eeb9f6ca2082e977c">e60ba6</a>
GitHub Action: Bump robinraju/release-downloader from 1.10 to 1.11 (<a
href="https://github.com/microsoft/mu_feature_dfci/pull/229">#229</a>)</li>
<li><a
href="https://github.com/microsoft/mu_feature_dfci/commit/98dabf9585976b3e62fdd942afef5567039a4c4f">98dabf</a>
pip: bump edk2-pytool-extensions from 0.27.6 to 0.27.9 (<a
href="https://github.com/microsoft/mu_feature_dfci/pull/231">#231</a>)</li>
<li><a
href="https://github.com/microsoft/mu_feature_dfci/commit/981a67c31e0334583b60ab08a3dd252c11e59432">981a67</a>
pip: bump edk2-pytool-extensions from 0.27.9 to 0.27.10 (<a
href="https://github.com/microsoft/mu_feature_dfci/pull/232">#232</a>)</li>
<li><a
href="https://github.com/microsoft/mu_feature_dfci/commit/c381d64eb91b0038222759459775742f205fa54c">c381d6</a>
pip: bump regex from 2024.5.15 to 2024.7.24 (<a
href="https://github.com/microsoft/mu_feature_dfci/pull/239">#239</a>)</li>
<li><a
href="https://github.com/microsoft/mu_feature_dfci/commit/0262f7d1ed8f74b817cb0c7655e2c2787f6980c6">0262f7</a>
pip: bump edk2-pytool-library from 0.21.8 to 0.21.9 (<a
href="https://github.com/microsoft/mu_feature_dfci/pull/238">#238</a>)</li>
<li><a
href="https://github.com/microsoft/mu_feature_dfci/commit/2dd22c3b6f9777e911098c5fd2219b1d97eaea53">2dd22c</a>
DfciPkg/DfciSettings.h: Add new DFCI settings (<a
href="https://github.com/microsoft/mu_feature_dfci/pull/240">#240</a>)</li>
<li><a
href="https://github.com/microsoft/mu_feature_dfci/commit/514e1526537f00134512fda810e60abb648a8959">514e15</a>
DfciPkg/DfciTests: fix refresh server pip failure (<a
href="https://github.com/microsoft/mu_feature_dfci/pull/236">#236</a>)</li>
<li><a
href="https://github.com/microsoft/mu_feature_dfci/commit/da68e5dab1b1fc5fbdb58a6d45c6c12147047bb6">da68e5</a>
DfciPkg/DfciTests: remove silicon-specific test (<a
href="https://github.com/microsoft/mu_feature_dfci/pull/237">#237</a>)</li>
</ul>
</details>

Signed-off-by: Project Mu Bot <[email protected]>

Signed-off-by: Project Mu Bot <[email protected]>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

impact:non-functional