Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Code comments an a NULL Library reference non existing code #75

Closed
1 task done
mikeytdisco opened this issue Apr 4, 2023 · 0 comments · Fixed by #76
Closed
1 task done

[Bug]: Code comments an a NULL Library reference non existing code #75

mikeytdisco opened this issue Apr 4, 2023 · 0 comments · Fixed by #76
Labels
state:needs-triage Needs to triaged to determine next steps type:bug Something isn't working urgency:low Little to no impact

Comments

@mikeytdisco
Copy link
Contributor

Is there an existing issue for this?

  • I have searched existing issues

Current Behavior

No change to behavior

Expected Behavior

No change to behavior

Steps To Reproduce

View the code

Build Environment

- OS(s):
- Tool Chain(s):
- Targets Impacted:

Version Information

Tag: V2.0.1

Urgency

Low

Are you going to fix this?

I will fix it

Do you need maintainer feedback?

No maintainer feedback needed

Anything else?

No response
@mikeytdisco mikeytdisco added state:needs-triage Needs to triaged to determine next steps type:bug Something isn't working labels Apr 4, 2023
@github-actions github-actions bot added the urgency:low Little to no impact label Apr 4, 2023
@mikeytdisco mikeytdisco mentioned this issue Apr 4, 2023
Merged
5 tasks
spbrogan pushed a commit that referenced this issue Apr 6, 2023
@mikeytdisco
Remove references to a function removed long ago (#76)
426e8d5 
## Description

Code comments and the library DfciUiSupportLibNull reference a function
no longer used. This removes the dead code from the NULL library, and
updates comments in the active code. Fixes #75

For each item, place an "x" in between `[` and `]` if true. Example:
`[x]`.
_(you can also check items in the GitHub UI)_

- [ ] Impacts functionality?

- [ ] Impacts security?

- [ ] Breaking change?

- [ ] Includes tests?

- [ ] Includes documentation?


## How This Was Tested

Not tested

## Integration Instructions

N/A
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
state:needs-triage Needs to triaged to determine next steps type:bug Something isn't working urgency:low Little to no impact
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove references to a function removed long ago mikeytdisco/mu_feature_dfci
1 participant
@mikeytdisco