Skip to content

Commit

Permalink
Remove references to a function removed long ago (#76)
Browse files Browse the repository at this point in the history
## Description

Code comments and the library DfciUiSupportLibNull reference a function
no longer used. This removes the dead code from the NULL library, and
updates comments in the active code. Fixes #75

For each item, place an "x" in between `[` and `]` if true. Example:
`[x]`.
_(you can also check items in the GitHub UI)_

- [ ] Impacts functionality?

- [ ] Impacts security?

- [ ] Breaking change?

- [ ] Includes tests?

- [ ] Includes documentation?


## How This Was Tested

Not tested

## Integration Instructions

N/A
  • Loading branch information
mikeytdisco authored Apr 6, 2023
1 parent 4cd4265 commit 426e8d5
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 31 deletions.
4 changes: 2 additions & 2 deletions DfciPkg/IdentityAndAuthManager/AuthManagerProvision.c
Original file line number Diff line number Diff line change
Expand Up @@ -617,7 +617,7 @@ ApplyNewIdentityPacket (
);

if (EFI_ERROR (Status)) {
DEBUG ((DEBUG_ERROR, "DfciUiGetAnswerFromUser failed %r\n", Status));
DEBUG ((DEBUG_ERROR, "LocalGetAnswerFromUser failed %r\n", Status));
if (Status == EFI_NOT_READY) {
Data->State = DFCI_PACKET_STATE_DATA_SYSTEM_ERROR;
Data->StatusCode = EFI_NOT_READY;
Expand All @@ -634,7 +634,7 @@ ApplyNewIdentityPacket (
}

if (Data->State != DFCI_PACKET_STATE_DATA_USER_APPROVED) {
DEBUG ((DEBUG_ERROR, "DfciUiGetAnswerFromUser - User Rejected Change\n"));
DEBUG ((DEBUG_ERROR, "LocalGetAnswerFromUser - User Rejected Change\n"));
goto CLEANUP;
}

Expand Down
29 changes: 0 additions & 29 deletions DfciPkg/Library/DfciUiSupportLibNull/DfciUiSupportLibNull.c
Original file line number Diff line number Diff line change
Expand Up @@ -105,35 +105,6 @@ DfciUiDisplayAuthDialog (
return EFI_UNSUPPORTED;
}

/**
This routine is called by DFCI to prompt a local user to confirm certificate
provisioning operations.

@param AuthMgrProtocol Supplies a pointer to the authentication
manager protocol.
@param TrustedCert Supplies a pointer to a trusted certificate.
@param TrustedCertSize Supplies the size in bytes of the trusted
certificate.
@param AuthToken Supplies a pointer that will receive an
authentication token.

@return EFI_NOT_READY Indicates that UI components are not available.
@return EFI_ACCESS_DENIED The user rejected the operation.
@return EFI_SUCCESS The user approved the operation.

**/
EFI_STATUS
EFIAPI
DfciUiGetAnswerFromUser (
DFCI_AUTHENTICATION_PROTOCOL *AuthMgrProtocol,
UINT8 *TrustedCert,
UINT16 TrustedCertSize,
OUT DFCI_AUTH_TOKEN *AuthToken
)
{
return EFI_SUCCESS;
}

/**
DfciUiExitSecurityBoundary

Expand Down

0 comments on commit 426e8d5

Please sign in to comment.