Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor ProviderValueAsAscii() #48

Merged

Conversation

wenbhou
Copy link
Contributor

@wenbhou wenbhou commented Mar 7, 2023

Description

Refactor ProviderValueAsAscii() and remove following macros to make it can allocate buffer with right size for each setting.
Fix #43

#define ENABLED_STRING_SIZE                (9)
#define ASSET_TAG_STRING_MAX_SIZE          (22)
#define SECURE_BOOT_ENUM_STRING_SIZE       (20)
#define SYSTEM_PASSWORD_STATE_STRING_SIZE  (30)
#define USB_PORT_STATE_STRING_SIZE         (20)
  • Impacts functionality?
    • Functionality - Does the change ultimately impact how firmware functions?
    • Examples: Add a new library, publish a new PPI, update an algorithm, ...
  • Impacts security?
    • Security - Does the change have a direct security impact on an application,
      flow, or firmware?
    • Examples: Crypto algorithm change, buffer overflow fix, parameter
      validation improvement, ...
  • Breaking change?
    • Breaking change - Will anyone consuming this change experience a break
      in build or boot behavior?
    • Examples: Add a new library class, move a module to a different repo, call
      a function in a new library class in a pre-existing module, ...
  • Includes tests?
    • Tests - Does the change include any explicit test code?
    • Examples: Unit tests, integration tests, robot tests, ...
  • Includes documentation?
    • Documentation - Does the change contain explicit documentation additions
      outside direct code modifications (and comments)?
    • Examples: Update readme file, add feature readme file, link to documentation
      on an a separate Web page, ...

How This Was Tested

Tested with SEMM tool. No regression seen.

Integration Instructions

N/A

@github-actions github-actions bot added the impact:non-functional Does not have a functional impact label Mar 7, 2023
@github-actions github-actions bot removed the impact:non-functional Does not have a functional impact label Mar 9, 2023
@makubacki makubacki added the type:bug Something isn't working label Mar 9, 2023
@makubacki makubacki force-pushed the personal/wenbhou/refactor_ProviderValueAsAscii branch from fa792bf to 10ab4d9 Compare March 9, 2023 19:25
DfciPkg/SettingsManager/SettingsManagerProvider.c Outdated Show resolved Hide resolved
DfciPkg/SettingsManager/SettingsManagerProvider.c Outdated Show resolved Hide resolved
DfciPkg/SettingsManager/SettingsManagerProvider.c Outdated Show resolved Hide resolved
DfciPkg/SettingsManager/SettingsManagerProvider.c Outdated Show resolved Hide resolved
@makubacki
Copy link
Member

@wenbhou, it looks like there's just uncrustify errors. Other than those, are you ready for this to be merged?

@wenbhou wenbhou requested review from makubacki and removed request for TaylorBeebe and kuqin12 March 10, 2023 14:27
@makubacki makubacki merged commit b0f6333 into microsoft:main Mar 10, 2023
@wenbhou wenbhou deleted the personal/wenbhou/refactor_ProviderValueAsAscii branch March 10, 2023 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Refactor ProviderValueAsAscii() to allocate buffer with right size for each setting
3 participants