[CHERRY-PICK] BoardModulePkg: Added Mock library for BiosIdLib #301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
impact:non-functional
VivianNK
force-pushed
the
personal/vnowkakeane/biosIdLib
branch
from
867e462 to
cb68166
Compare
VivianNK
changed the title
VivianNK
force-pushed
the
personal/vnowkakeane/biosIdLib
branch
from
cb68166 to
42c8d78
Compare
VivianNK
changed the title
apop5
approved these changes
Oct 4, 2024
Flickdm
approved these changes
Oct 4, 2024
makubacki
reviewed
Oct 4, 2024
BoardModulePkg/Test/Mock/Include/GoogleTest/Library/MockBiosIdLib.h
Outdated
Show resolved
Hide resolved
makubacki
reviewed
Oct 4, 2024
BoardModulePkg/Test/Mock/Library/GoogleTest/MockBiosIdLib/MockBiosIdLib.inf
Show resolved
Hide resolved
|
If you don't want to fix those to keep this a straight cherry-pick that's fine. They're not that big of a deal. |
makubacki
approved these changes
Oct 4, 2024
Added a gmock for GoogleTests that pull in BiosIdLib. Cc: Eric Dong <[email protected]> Cc: Liming Gao <[email protected]> Signed-off-by: Vivian Nowka-Keane <[email protected]>
VivianNK
force-pushed
the
personal/vnowkakeane/biosIdLib
branch
from
42c8d78 to
53c84c4
Compare
v-bhavanisu
added a commit
to v-bhavanisu/mu_common_intel_min_platform
that referenced
this pull request
Oct 18, 2024
…soft#301) ## Description Added a gmock for GoogleTests that pull in BiosIdLib. Cherry picked from edk2_platforms [c53db4dc8bbc6cec6016792b9e08b1f0630498ae](tianocore/edk2-platforms@c53db4d) Amended to add newline in header file description. - [ ] Impacts functionality? - [ ] Impacts security? - [ ] Breaking change? - [ ] Includes tests? - [ ] Includes documentation? ## How This Was Tested Consumed mock in GoogleTest ## Integration Instructions N/A Signed-off-by: Vivian Nowka-Keane <[email protected]> Co-authored-by: Bhavani Subramanian <[email protected]>
apop5
pushed a commit
that referenced
this pull request
Oct 18, 2024
## Description Added a gmock for GoogleTests that pull in BiosIdLib. Cherry picked from edk2_platforms [c53db4dc8bbc6cec6016792b9e08b1f0630498ae](tianocore/edk2-platforms@c53db4d) Amended to add newline in header file description. - [ ] Impacts functionality? - [ ] Impacts security? - [ ] Breaking change? - [ ] Includes tests? - [ ] Includes documentation? ## How This Was Tested Consumed mock in GoogleTest ## Integration Instructions N/A Signed-off-by: Vivian Nowka-Keane <[email protected]> Co-authored-by: Bhavani Subramanian <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added a gmock for GoogleTests that pull in BiosIdLib.
Cherry picked from edk2_platforms
c53db4dc8bbc6cec6016792b9e08b1f0630498ae
Amended to add newline in header file description.
How This Was Tested
Consumed mock in GoogleTest
Integration Instructions
N/A