Skip to content

Commit

Permalink
Removed references to openssllib and it's associated libraries (#230)
Browse files Browse the repository at this point in the history
## Description

There are some references to BaseCryptLib and Openssl in package dsc
files. In MU_BASECORE Openssl and its BaseCryptLib implementations were
removed so we need to update to using the NULL lib.

- [ ] Impacts functionality?
- **Functionality** - Does the change ultimately impact how firmware
functions?
- Examples: Add a new library, publish a new PPI, update an algorithm,
...
- [ ] Impacts security?
- **Security** - Does the change have a direct security impact on an
application,
    flow, or firmware?
  - Examples: Crypto algorithm change, buffer overflow fix, parameter
    validation improvement, ...
- [ ] Breaking change?
- **Breaking change** - Will anyone consuming this change experience a
break
    in build or boot behavior?
- Examples: Add a new library class, move a module to a different repo,
call
    a function in a new library class in a pre-existing module, ...
- [ ] Includes tests?
  - **Tests** - Does the change include any explicit test code?
  - Examples: Unit tests, integration tests, robot tests, ...
- [ ] Includes documentation?
- **Documentation** - Does the change contain explicit documentation
additions
    outside direct code modifications (and comments)?
- Examples: Update readme file, add feature readme file, link to
documentation
    on an a separate Web page, ...

## How This Was Tested

Tested with CI

## Integration Instructions

N/A
  • Loading branch information
kenlautner authored Jan 19, 2024
1 parent cadd22b commit b0fd061
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 6 deletions.
6 changes: 4 additions & 2 deletions MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc
Original file line number Diff line number Diff line change
Expand Up @@ -151,8 +151,10 @@
#
# CryptLib
#
IntrinsicLib|CryptoPkg/Library/IntrinsicLib/IntrinsicLib.inf
OpensslLib|CryptoPkg/Library/OpensslLib/OpensslLib.inf

# MU_CHANGE - Remove Openssl crypto references
#IntrinsicLib|CryptoPkg/Library/IntrinsicLib/IntrinsicLib.inf
#OpensslLib|CryptoPkg/Library/OpensslLib/OpensslLib.inf

RngLib|MdePkg/Library/BaseRngLib/BaseRngLib.inf

Expand Down
6 changes: 3 additions & 3 deletions MinPlatformPkg/Include/Dsc/CoreDxeLib.dsc
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@

TpmMeasurementLib|SecurityPkg/Library/DxeTpmMeasurementLib/DxeTpmMeasurementLib.inf

BaseCryptLib|CryptoPkg/Library/BaseCryptLib/BaseCryptLib.inf
#BaseCryptLib|CryptoPkg/Library/BaseCryptLib/BaseCryptLib.inf MU_CHANGE - Remove Openssl crypto references

Tpm2DeviceLib|SecurityPkg/Library/Tpm2DeviceLibRouter/Tpm2DeviceLibRouterDxe.inf
HashLib|SecurityPkg/Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRouterDxe.inf
Expand Down Expand Up @@ -89,7 +89,7 @@

CpuExceptionHandlerLib|UefiCpuPkg/Library/CpuExceptionHandlerLib/SmmCpuExceptionHandlerLib.inf
Tcg2PhysicalPresenceLib|SecurityPkg/Library/SmmTcg2PhysicalPresenceLib/SmmTcg2PhysicalPresenceLib.inf
BaseCryptLib|CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf
#BaseCryptLib|CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf MU_CHANGE - Remove Openssl crypto references
VariableReadLib|MinPlatformPkg/Library/SmmVariableReadLib/TraditionalMmVariableReadLib.inf
VariableWriteLib|MinPlatformPkg/Library/SmmVariableWriteLib/TraditionalMmVariableWriteLib.inf

Expand All @@ -105,7 +105,7 @@

[LibraryClasses.common.DXE_RUNTIME_DRIVER]
ReportStatusCodeLib|MdeModulePkg/Library/RuntimeDxeReportStatusCodeLib/RuntimeDxeReportStatusCodeLib.inf
BaseCryptLib|CryptoPkg/Library/BaseCryptLib/RuntimeCryptLib.inf
#BaseCryptLib|CryptoPkg/Library/BaseCryptLib/RuntimeCryptLib.inf MU_CHANGE - Remove Openssl crypto references
VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLibRuntimeDxe.inf

[LibraryClasses.common.UEFI_APPLICATION]
Expand Down
2 changes: 1 addition & 1 deletion MinPlatformPkg/Include/Dsc/CorePeiLib.dsc
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@
TimerLib|PcAtChipsetPkg/Library/AcpiTimerLib/PeiAcpiTimerLib.inf

[LibraryClasses.common.PEIM]
BaseCryptLib|CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf
#BaseCryptLib|CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf MU_CHANGE - Remove Openssl crypto references

Tpm2DeviceLib|SecurityPkg/Library/Tpm2DeviceLibRouter/Tpm2DeviceLibRouterPei.inf
HashLib|SecurityPkg/Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRouterPei.inf
Expand Down

0 comments on commit b0fd061

Please sign in to comment.