BaseTools: Add ProductDataFormatter [Rebase & FF] #942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
impact:non-functional
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/202405 #942 +/- ##
=================================================
Coverage ? 43.42%
=================================================
Files ? 180
Lines ? 25101
Branches ? 6016
=================================================
Hits ? 10901
Misses ? 14135
Partials ? 65
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
makubacki
reviewed
Jun 25, 2024
BaseTools/Source/Python/ProductDataFormatter/ProductDataFormatter.py
Outdated
Show resolved
Hide resolved
makubacki
reviewed
Jun 25, 2024
makubacki
reviewed
Jun 25, 2024
makubacki
reviewed
Jun 25, 2024
makubacki
reviewed
Jun 25, 2024
makubacki
reviewed
Jun 25, 2024
makubacki
changed the title
makubacki
changed the title
kenlautner
force-pushed
the
personal/klautner/add_OemDataFormatter
branch
2 times, most recently
from
a04b72b to
17323a8
Compare
os-d
reviewed
Jun 28, 2024
kenlautner
force-pushed
the
personal/klautner/add_OemDataFormatter
branch
2 times, most recently
from
a9518ba to
6ccf5b9
Compare
os-d
approved these changes
Jun 30, 2024
|
PR Title should be ProductDataFormatter |
makubacki
reviewed
Jul 1, 2024
makubacki
reviewed
Jul 1, 2024
makubacki
approved these changes
Jul 1, 2024
kenlautner
changed the title
5 tasks
kenlautner
force-pushed
the
personal/klautner/add_OemDataFormatter
branch
3 times, most recently
from
5570976 to
bbe90bd
Compare
Adds a new build rule for OEM data files which are structured compiled data. The rule provides support for MSFT, GCC, and Clang toolchains. Deletes the intermediate binary files in a module output directory after the final binary is written using the files. This is important to prevent intermediate files from potentially being used in future incremental builds if the corresponding source file is no longer present. BaseTools/OemDataFormatter: Rename to ProductDataFormatter Renames the tool to ProductDataFormatter to align with a change in data name from "OEM data" to "product data".
kenlautner
force-pushed
the
personal/klautner/add_OemDataFormatter
branch
from
bbe90bd to
017f59f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The following commits from 202311 are linked here:
d188c8d
7a6a30a
86dfe9b
The changes are listed below:
Added versioning to the buildrule_template.
Added the OemDataFormatter to basetools. This includes the name change to ProductDataFormatter.
flow, or firmware?
validation improvement, ...
in build or boot behavior?
a function in a new library class in a pre-existing module, ...
outside direct code modifications (and comments)?
on an a separate Web page, ...
How This Was Tested
CI
Integration Instructions
N/A