2405: Reset Architecture Changes [Rebase & FF] #935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makubacki
added
type:enhancement
makubacki
force-pushed
the
2405_reset_arch_changes
branch
2 times, most recently
from
88eaa48 to
15492c1
Compare
os-d
approved these changes
Jun 21, 2024
kenlautner
approved these changes
Jun 21, 2024
Uses a new library class to represent the reset library linked against core reset modules. This allows differentiation from the reset library instance linked against all other modules that may depend on functionality produced by the core reset module. Co-authored-by: Michael Kubacki <[email protected]> Signed-off-by: Michael Kubacki <[email protected]>
If a capsule indicates it should initiate a reset, reset with the subtype gCapsuleArmedResetGuid using the helper function in ResetUtilityLib. Signed-off-by: Michael Kubacki <[email protected]>
Removes the EfiResetSystem() API from the library. ResetSystemLib can be used for reset. Signed-off-by: Michael Kubacki <[email protected]>
Adds instrumentation to the PageTbl and SmiPFHandler code to allow reset (instead of halts) on page faults. This enables automated testing of fault detection and handling. Co-authored-by: Michael Kubacki <[email protected]> Signed-off-by: Michael Kubacki <[email protected]>
makubacki
force-pushed
the
2405_reset_arch_changes
branch
from
15492c1 to
2e0758e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/202405 #935 +/- ##
=================================================
Coverage ? 23.35%
=================================================
Files ? 197
Lines ? 23531
Branches ? 6980
=================================================
Hits ? 5495
Misses ? 17039
Partials ? 997
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Contains a set of changes related to reset architecture. The main
feature included is
HwResetSystemLib.Closes #870
UefiCpuPkg: Add support for testing the SMM page protections
Adds instrumentation to the PageTbl and SmiPFHandler code to
allow reset (instead of halts) on page faults.
This enables automated testing of fault detection and handling.
MdeModulePkg: Perform capsule reset with subtype
If a capsule indicates it should initiate a reset, reset with the
subtype gCapsuleArmedResetGuid using the helper function in
ResetUtilityLib.
MdePkg: Remove EfiResetSystem() from UefiRuntimeLib
Removes the EfiResetSystem() API from the library. ResetSystemLib
can be used for reset.
UefiCpuPkg: Add support for testing the SMM page protections
Adds instrumentation to the PageTbl and SmiPFHandler code to
allow reset (instead of halts) on page faults.
This enables automated testing of fault detection and handling.
How This Was Tested
Integration Instructions
HwResetSystemLibto the platform build that linksagainst core reset modules like
ResetSystemPei. Other modules shouldcontinue to use
ResetSystemLibwhich may locate the Reset PPI/Protocolproduced by the core reset driver.