Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Rebase & FF] 202405: Integration Policy Service Feature #918

Merged
merged 5 commits into from
Jul 8, 2024

Conversation

cfernald
Copy link
Contributor

Description

Integrate policy service relate changes. Originally from the following commits.

Issue #867

cherry-picks from:
c8f9883
058d734
ad777e9
fbb9af5
ab9d819
a8dee78
599ccfc
13f011b
c09449a
238909f

  • Impacts functionality?
  • Impacts security?
  • Breaking change?
  • Includes tests?
  • Includes documentation?

How This Was Tested

N/A

Integration Instructions

N/A

@cfernald cfernald changed the title Integration Policy Service Feature [Rebase & FF] 202405: Integration Policy Service Feature Jun 17, 2024
@cfernald cfernald force-pushed the 2405_policy_service branch from 91008b9 to c41654d Compare June 20, 2024 17:22
@github-actions github-actions bot added the language:python Pull requests that update Python code label Jun 20, 2024
@cfernald cfernald force-pushed the 2405_policy_service branch from c54c0ea to 1566720 Compare June 28, 2024 20:39
@codecov-commenter
Copy link

codecov-commenter commented Jun 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release/202405@ddf32c3). Learn more about missing BASE report.

Additional details and impacted files
@@                Coverage Diff                @@
##             release/202405     #918   +/-   ##
=================================================
  Coverage                  ?    1.23%           
=================================================
  Files                     ?     1421           
  Lines                     ?   358180           
  Branches                  ?     4336           
=================================================
  Hits                      ?     4412           
  Misses                    ?   353709           
  Partials                  ?       59           
Flag Coverage Δ
MdeModulePkg 0.20% <ø> (?)
MdePkg 5.41% <ø> (?)
NetworkPkg 0.55% <ø> (?)
UefiCpuPkg 4.80% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cfernald cfernald force-pushed the 2405_policy_service branch from 1566720 to 3be2384 Compare July 1, 2024 20:47
@cfernald cfernald requested a review from os-d July 1, 2024 20:48
PolicyServicePkg/Include/Library/PolicyLib.h Outdated Show resolved Hide resolved
PolicyServicePkg/README.md Show resolved Hide resolved
PolicyServicePkg/PolicyServicePkg.dec Show resolved Hide resolved
@cfernald cfernald force-pushed the 2405_policy_service branch 2 times, most recently from 857b922 to 6468133 Compare July 3, 2024 20:00
@cfernald cfernald enabled auto-merge (rebase) July 3, 2024 22:10
cfernald and others added 5 commits July 7, 2024 20:13
… across phases

Creates a policy service for handling producing and creating policy accross phases.

Issue microsoft#867

cherry-pick from 238909f, c09449a, 13f011b, a8dee78, ab9d819, fbb9af5, 058d734
This change introduces automatically generated structure header definitions and their versioned accessors. This change is based on Intel's slimbootloader feature.

Issue microsoft#867

cherry-pick from c09449a
…raditional MM (microsoft#461)

Issue microsoft#867

cherry-pick from ad777e9

Please ensure you have read the [contribution
docs](https://github.com/microsoft/mu/blob/master/CONTRIBUTING.md) prior
to submitting the pull request. In particular,
[pull request
guidelines](https://github.com/microsoft/mu/blob/master/CONTRIBUTING.md#pull-request-best-practices).

Refactoring the MM implementation to support both Standalone MM and
Traditional MM

1. Add DXE_SMM_DRIVER to LIBRARY_CLASS of MmPolicyLib.inf
2. Refactor the PolicyMm module to have a common entrypoint, and both
Standalone MM and Traditional MM entrypoint call the common entrypoint.
3. Add Traditional MM description to Readme.md.

This PR resolves microsoft#460.

For each item, place an "x" in between `[` and `]` if true. Example:
`[x]`.
_(you can also check items in the GitHub UI)_

- [x] Impacts functionality?
- **Functionality** - Does the change ultimately impact how firmware
functions?
- Examples: Add a new library, publish a new PPI, update an algorithm,
...
- [ ] Impacts security?
- **Security** - Does the change have a direct security impact on an
application,
    flow, or firmware?
  - Examples: Crypto algorithm change, buffer overflow fix, parameter
    validation improvement, ...
- [ ] Breaking change?
- **Breaking change** - Will anyone consuming this change experience a
break
    in build or boot behavior?
- Examples: Add a new library class, move a module to a different repo,
call
    a function in a new library class in a pre-existing module, ...
- [ ] Includes tests?
  - **Tests** - Does the change include any explicit test code?
  - Examples: Unit tests, integration tests, robot tests, ...
- [x] Includes documentation?
- **Documentation** - Does the change contain explicit documentation
additions
    outside direct code modifications (and comments)?
- Examples: Update readme file, add feature readme file, link to
documentation
    on an a separate Web page, ...

Verified with the CI build

N/A
Issue microsoft#867

cherry-pick from c8f9883

Please ensure you have read the [contribution
docs](https://github.com/microsoft/mu/blob/master/CONTRIBUTING.md) prior
to submitting the pull request. In particular,
[pull request
guidelines](https://github.com/microsoft/mu/blob/master/CONTRIBUTING.md#pull-request-best-practices).

Added Mock GoogleTest folder for PolicyLibCommon

For each item, place an "x" in between `[` and `]` if true. Example:
`[x]`.
_(you can also check items in the GitHub UI)_

- [ ] Impacts functionality?
- **Functionality** - Does the change ultimately impact how firmware
functions?
- Examples: Add a new library, publish a new PPI, update an algorithm,
...
- [ ] Impacts security?
- **Security** - Does the change have a direct security impact on an
application,
    flow, or firmware?
  - Examples: Crypto algorithm change, buffer overflow fix, parameter
    validation improvement, ...
- [ ] Breaking change?
- **Breaking change** - Will anyone consuming this change experience a
break
    in build or boot behavior?
- Examples: Add a new library class, move a module to a different repo,
call
    a function in a new library class in a pre-existing module, ...
- [ ] Includes tests?
  - **Tests** - Does the change include any explicit test code?
  - Examples: Unit tests, integration tests, robot tests, ...
- [ ] Includes documentation?
- **Documentation** - Does the change contain explicit documentation
additions
    outside direct code modifications (and comments)?
- Examples: Update readme file, add feature readme file, link to
documentation
    on an a separate Web page, ...

Added this mock lib definition and declaration to one of the library
under Gen 11 and made sure local build is successful

N/A
Issue microsoft#867
cherri-picked from 5f8b6a9

Please ensure you have read the [contribution
docs](https://github.com/microsoft/mu/blob/master/CONTRIBUTING.md) prior
to submitting the pull request. In particular,
[pull request
guidelines](https://github.com/microsoft/mu/blob/master/CONTRIBUTING.md#pull-request-best-practices).

This change removed the AARCH64 support for the host based unit tests
for PolicyServicesPkg because this is not yet supported.

Removing the support in this DSC file to fix the broken pipeline build
on AARCH64 systems.

For each item, place an "x" in between `[` and `]` if true. Example:
`[x]`.
_(you can also check items in the GitHub UI)_

- [x] Impacts functionality?
- **Functionality** - Does the change ultimately impact how firmware
functions?
- Examples: Add a new library, publish a new PPI, update an algorithm,
...
- [ ] Impacts security?
- **Security** - Does the change have a direct security impact on an
application,
    flow, or firmware?
  - Examples: Crypto algorithm change, buffer overflow fix, parameter
    validation improvement, ...
- [ ] Breaking change?
- **Breaking change** - Will anyone consuming this change experience a
break
    in build or boot behavior?
- Examples: Add a new library class, move a module to a different repo,
call
    a function in a new library class in a pre-existing module, ...
- [ ] Includes tests?
  - **Tests** - Does the change include any explicit test code?
  - Examples: Unit tests, integration tests, robot tests, ...
- [ ] Includes documentation?
- **Documentation** - Does the change contain explicit documentation
additions
    outside direct code modifications (and comments)?
- Examples: Update readme file, add feature readme file, link to
documentation
    on an a separate Web page, ...

N/A

N/A
@cfernald cfernald force-pushed the 2405_policy_service branch from 6468133 to f178e4d Compare July 8, 2024 03:13
@cfernald cfernald merged commit 4c7d0c5 into microsoft:release/202405 Jul 8, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
language:python Pull requests that update Python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants