Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Mock for SafeIntLib #1235

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

TsunFeng
Copy link
Contributor

@TsunFeng TsunFeng commented Dec 3, 2024

Description

Create Mock for SafeIntLib

For details on how to complete these options and their meaning refer to CONTRIBUTING.md.

  • Impacts functionality?
  • Impacts security?
  • Breaking change?
  • Includes tests?
  • Includes documentation?
  • Backport to release branch?

How This Was Tested

Unit tests component can call these mock functions success

Integration Instructions

N/A

@github-actions github-actions bot added impact:non-functional Does not have a functional impact type:backport Backport changes in a dev branch PR to its release branch. labels Dec 3, 2024
@codecov-commenter
Copy link

codecov-commenter commented Dec 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 1.60%. Comparing base (f72f269) to head (5f43d72).

Additional details and impacted files
@@             Coverage Diff             @@
##           dev/202405    #1235   +/-   ##
===========================================
  Coverage        1.60%    1.60%           
===========================================
  Files            1377     1377           
  Lines          359246   359246           
  Branches         5524     5524           
===========================================
  Hits             5760     5760           
  Misses         353379   353379           
  Partials          107      107           
Flag Coverage Δ
MdeModulePkg 0.67% <ø> (ø)
MdePkg 5.60% <ø> (ø)
NetworkPkg 0.55% <ø> (ø)
PolicyServicePkg 30.41% <ø> (ø)
UefiCpuPkg 4.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TsunFeng TsunFeng marked this pull request as ready for review December 4, 2024 01:32
@apop5 apop5 requested a review from VivianNK December 6, 2024 17:06
@TsunFeng TsunFeng force-pushed the user/TsunFeng/MockSafeIntLib branch from 9f77203 to ba8af31 Compare December 9, 2024 02:02
@TsunFeng
Copy link
Contributor Author

Hi @VivianNK,
Could you take some time to review this PR? Thanks.

Copy link
Contributor

@VivianNK VivianNK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please link to an edk2 PR

@TsunFeng TsunFeng force-pushed the user/TsunFeng/MockSafeIntLib branch from ba8af31 to 31c910e Compare December 11, 2024 01:45
@TsunFeng
Copy link
Contributor Author

The edk2 PR has been created in:
tianocore/edk2#6504

@TsunFeng TsunFeng force-pushed the user/TsunFeng/MockSafeIntLib branch from 31c910e to d602171 Compare December 12, 2024 02:02
@TsunFeng TsunFeng force-pushed the user/TsunFeng/MockSafeIntLib branch from d602171 to 5f43d72 Compare December 13, 2024 07:27
@apop5 apop5 merged commit d12fd4f into microsoft:dev/202405 Dec 18, 2024
31 checks passed
ProjectMuBot pushed a commit that referenced this pull request Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact:non-functional Does not have a functional impact type:backport Backport changes in a dev branch PR to its release branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants