Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mock functions under MockUefiRuntimeServicesTableLib, MockUefiRuntimeServicesTableLib and Create Mock for DxeServicesTableLib #1109

Merged
merged 4 commits into from
Sep 9, 2024

Conversation

YiTa-AMI
Copy link
Contributor

Description

Add mock functions under MockUefiRuntimeServicesTableLib, MockUefiRuntimeServicesTableLib and Create Mock for DxeServicesTableLib

For details on how to complete to complete these options and their meaning refer to CONTRIBUTING.md.

  • Impacts functionality?
  • Impacts security?
  • Breaking change?
  • Includes tests?
  • Includes documentation?

How This Was Tested

Unit tests component can call these mock functions success

Integration Instructions

N/A

@github-actions github-actions bot added the impact:non-functional Does not have a functional impact label Aug 18, 2024
@YiTa-AMI
Copy link
Contributor Author

@microsoft-github-policy-service agree company="Microsoft"

@YiTa-AMI
Copy link
Contributor Author

YiTa-AMI commented Aug 19, 2024

Hi @VivianNK , @apop5 and @os-d
Would you kindly help review this change?
Thanks,
YiTa

@VivianNK VivianNK self-requested a review August 23, 2024 23:34
@VivianNK VivianNK requested a review from apop5 August 27, 2024 19:51
@codecov-commenter
Copy link

codecov-commenter commented Sep 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 1.35%. Comparing base (104c355) to head (12b667d).

Additional details and impacted files
@@               Coverage Diff               @@
##           release/202311    #1109   +/-   ##
===============================================
  Coverage            1.35%    1.35%           
===============================================
  Files                1303     1303           
  Lines              333841   333841           
  Branches             5103     5103           
===============================================
  Hits                 4512     4512           
  Misses             329246   329246           
  Partials               83       83           
Flag Coverage Δ
MdeModulePkg 0.68% <ø> (ø)
MdePkg 5.40% <ø> (ø)
NetworkPkg 0.55% <ø> (ø)
PolicyServicePkg 30.41% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@VivianNK VivianNK merged commit 5aa1be5 into microsoft:release/202311 Sep 9, 2024
31 checks passed
@YiTa-AMI YiTa-AMI deleted the MockBS branch September 10, 2024 05:57
VivianNK pushed a commit to VivianNK/mu_basecore that referenced this pull request Sep 12, 2024
…timeServicesTableLib and Create Mock for DxeServicesTableLib (microsoft#1109)

Add mock functions under MockUefiRuntimeServicesTableLib,
MockUefiRuntimeServicesTableLib and Create Mock for DxeServicesTableLib

For details on how to complete to complete these options and their
meaning refer to
[CONTRIBUTING.md](https://github.com/microsoft/mu/blob/HEAD/CONTRIBUTING.md).

- [ ] Impacts functionality?
- [ ] Impacts security?
- [ ] Breaking change?
- [ ] Includes tests?
- [ ] Includes documentation?

Unit tests component can call these mock functions success

N/A

---------

Signed-off-by: YiTa-AMI <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact:non-functional Does not have a functional impact
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants