[202405][REBASE&FF] Variable Argument List macros reversions

[Javagedes]

Description

This reverts the following commits:

• 6f5dd60

• 01f1b2d

• Impacts functionality?

  • Functionality - Does the change ultimately impact how firmware functions?
  • Examples: Add a new library, publish a new PPI, update an algorithm, ...

• Impacts security?

  • Security - Does the change have a direct security impact on an application,
    flow, or firmware?
  • Examples: Crypto algorithm change, buffer overflow fix, parameter
    validation improvement, ...

• [] Breaking change?

  • Breaking change - Will anyone consuming this change experience a break
    in build or boot behavior?
  • Examples: Add a new library class, move a module to a different repo, call
    a function in a new library class in a pre-existing module, ...

• Includes tests?

  • Tests - Does the change include any explicit test code?
  • Examples: Unit tests, integration tests, robot tests, ...

• Includes documentation?

  • Documentation - Does the change contain explicit documentation additions
    outside direct code modifications (and comments)?
  • Examples: Update readme file, add feature readme file, link to documentation
    on an a separate Web page, ...

How This Was Tested

Confirmed this does not affect multiple platform builds using VS compiler

Integration Instructions

N/A

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release/202405@63fc132). Learn more about missing BASE report.

Additional details and impacted files

@@                Coverage Diff                @@
##             release/202405    #1089   +/-   ##
=================================================
  Coverage                  ?    1.59%           
=================================================
  Files                     ?     1448           
  Lines                     ?   361057           
  Branches                  ?     5553           
=================================================
  Hits                      ?     5766           
  Misses                    ?   355184           
  Partials                  ?      107           

Flag	Coverage Δ
MdeModulePkg	0.68% <ø> (?)
MdePkg	5.41% <ø> (?)
NetworkPkg	0.55% <ø> (?)
PolicyServicePkg	30.41% <ø> (?)
UefiCpuPkg	4.77% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[os-d]

We can revert this in the same PR: 7281ec2297. Also, I don't think this needs to be a breaking change. We do not believe any platform will break because of this, nor are there integration steps to fix it, so this would go in general category of shouldn't break but if it does, let us know.

[makubacki]

I will approve. Waiting for @Javagedes to get back on an additional platform build that I recommended to test.

[Javagedes]

We can revert this in the same PR: 7281ec2297. Also, I don't think this needs to be a breaking change. We do not believe any platform will break because of this, nor are there integration steps to fix it, so this would go in general category of shouldn't break but if it does, let us know.

Sounds good. I was being overly pessamistic with marking it as a breaking change. I'll undo that portion and also revert the PR you mentioned, as a REBASE&FF

[Javagedes]

@makubacki The additional platform was confirmed to successfully build on windows for DEBUG and RELEASE targets.