Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MuCodeQlQueries.qls and pin to the 0.9.12 codeq/cpp-queries pack #1062

Merged

Conversation

makubacki
Copy link
Member

Description

Adds the MuCodeQlQueries.qls file and changes the CodeQlAnalyzePlugin to use MuCodeQlQueries instead of the edk2 CodeQlQueries file. This runs the CodeQL queries that project mu cares about instead of the edk2 CodeQL queries that don't all apply.

  • Impacts functionality?
  • Impacts security?
  • Breaking change?
  • Includes tests?
  • Includes documentation?

How This Was Tested

  • 2311 transfer

Integration Instructions

  • MuCodeQlQueries.qls should be used by Project Mu based platforms

Adds the MuCodeQlQueries.qls file and changes the CodeQlAnalyzePlugin
to use MuCodeQlQueries instead of the edk2 CodeQlQueries file. This runs
the CodeQL queries that project mu cares about instead of the edk2
CodeQL queries that don't all apply.

Signed-off-by: Michael Kubacki <[email protected]>
@makubacki makubacki requested review from os-d and apop5 July 25, 2024 17:21
@makubacki makubacki self-assigned this Jul 25, 2024
@github-actions github-actions bot added language:python Pull requests that update Python code impact:non-functional Does not have a functional impact labels Jul 25, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jul 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release/202405@5bfab09). Learn more about missing BASE report.

Additional details and impacted files
@@                Coverage Diff                @@
##             release/202405    #1062   +/-   ##
=================================================
  Coverage                  ?    1.51%           
=================================================
  Files                     ?     1436           
  Lines                     ?   359840           
  Branches                  ?     5355           
=================================================
  Hits                      ?     5457           
  Misses                    ?   354286           
  Partials                  ?       97           
Flag Coverage Δ
MdeModulePkg 0.68% <ø> (?)
MdePkg 5.41% <ø> (?)
NetworkPkg 0.55% <ø> (?)
UefiCpuPkg 4.75% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@makubacki makubacki merged commit 1e6d5a3 into microsoft:release/202405 Jul 25, 2024
36 checks passed
apop5 pushed a commit to apop5/mu_basecore that referenced this pull request Jan 2, 2025
…icrosoft#1062)

Adds the MuCodeQlQueries.qls file and changes the CodeQlAnalyzePlugin to
use MuCodeQlQueries instead of the edk2 CodeQlQueries file. This runs
the CodeQL queries that project mu cares about instead of the edk2
CodeQL queries that don't all apply.

- [ ] Impacts functionality?
- [ ] Impacts security?
- [ ] Breaking change?
- [ ] Includes tests?
- [ ] Includes documentation?

MuCodeQlQueries.qls should be used by Project Mu based platforms

Signed-off-by: Michael Kubacki <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact:non-functional Does not have a functional impact language:python Pull requests that update Python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants