[REBASE&FF][202405] Restore TPL requirements for WaitForEvent() #1049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
language:python
Javagedes
force-pushed
the
personal/joeyvagedes/on-offs
branch
from
33e5d06 to
3c79382
Compare
Javagedes
force-pushed
the
personal/joeyvagedes/on-offs
branch
from
3c79382 to
00a1e89
Compare
os-d
reviewed
Jul 19, 2024
os-d
approved these changes
Jul 19, 2024
Flickdm
approved these changes
Jul 19, 2024
VivianNK
reviewed
Jul 19, 2024
VivianNK
reviewed
Jul 19, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/202405 #1049 +/- ##
=================================================
Coverage ? 0.89%
=================================================
Files ? 938
Lines ? 316208
Branches ? 2288
=================================================
Hits ? 2826
Misses ? 313351
Partials ? 31
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
VivianNK
approved these changes
Jul 19, 2024
Javagedes
force-pushed
the
personal/joeyvagedes/on-offs
branch
2 times, most recently
from
8c96cd4 to
c5dc9a6
Compare
Javagedes
changed the title
makubacki
reviewed
Jul 19, 2024
makubacki
reviewed
Jul 19, 2024
makubacki
reviewed
Jul 19, 2024
makubacki
approved these changes
Jul 19, 2024
Javagedes
force-pushed
the
personal/joeyvagedes/on-offs
branch
3 times, most recently
from
c8e90e0 to
7455db5
Compare
Restore TPL Requirements for WaitForEvent() and allow a platform to conditionally install a protocol that provides an interface to the internal WaitForEvent() that does not have TPL requirements.
Javagedes
force-pushed
the
personal/joeyvagedes/on-offs
branch
from
7455db5 to
bf96a2f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Restores TPL requirements for WaitForEvent as removed in c3acc1f to ensure the Event based Self Certification Tests (SCT)s pass, but allow a platform to produce a wait for event protocol that does not have the TPL_APPLICATION requirements.
Includes:
47273abc00
Impacts functionality?
Impacts security?
flow, or firmware?
validation improvement, ...
Breaking change?
in build or boot behavior?
a function in a new library class in a pre-existing module, ...
Includes tests?
Includes documentation?
outside direct code modifications (and comments)?
on an a separate Web page, ...
How This Was Tested
202311
Integration Instructions
202311