Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Rebase & FF] 202405: Add more support for Windows Capsules #1002

Merged

Conversation

VivianNK
Copy link
Contributor

@VivianNK VivianNK commented Jun 28, 2024

Description

Cherry-picked from the following commits:
621b31e
ac8ba93
8256e15
2a29c92

  • Impacts functionality?
    • Functionality - Does the change ultimately impact how firmware functions?
    • Examples: Add a new library, publish a new PPI, update an algorithm, ...
  • Impacts security?
    • Security - Does the change have a direct security impact on an application,
      flow, or firmware?
    • Examples: Crypto algorithm change, buffer overflow fix, parameter
      validation improvement, ...
  • Breaking change?
    • Breaking change - Will anyone consuming this change experience a break
      in build or boot behavior?
    • Examples: Add a new library class, move a module to a different repo, call
      a function in a new library class in a pre-existing module, ...
  • Includes tests?
    • Tests - Does the change include any explicit test code?
    • Examples: Unit tests, integration tests, robot tests, ...
  • Includes documentation?
    • Documentation - Does the change contain explicit documentation additions
      outside direct code modifications (and comments)?
    • Examples: Update readme file, add feature readme file, link to documentation
      on an a separate Web page, ...

How This Was Tested

N/A

Integration Instructions

N/A

@github-actions github-actions bot added the language:python Pull requests that update Python code label Jun 28, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jun 28, 2024

Codecov Report

Attention: Patch coverage is 0% with 83 lines in your changes missing coverage. Please review.

Please upload report for BASE (release/202405@4321868). Learn more about missing BASE report.

Files Patch % Lines
...kg/Library/DxeCapsuleLibFmp/DxeCapsuleProcessLib.c 0.00% 57 Missing ⚠️
...rary/CapsulePersistLibNull/CapsulePersistLibNull.c 0.00% 13 Missing ⚠️
...ModulePkg/Library/DxeCapsuleLibFmp/DxeCapsuleLib.c 0.00% 12 Missing ⚠️
...ePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull.c 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##             release/202405    #1002   +/-   ##
=================================================
  Coverage                  ?    1.25%           
=================================================
  Files                     ?     1425           
  Lines                     ?   358731           
  Branches                  ?     4391           
=================================================
  Hits                      ?     4495           
  Misses                    ?   354175           
  Partials                  ?       61           
Flag Coverage Δ
MdeModulePkg 0.24% <0.00%> (?)
MdePkg 5.41% <ø> (?)
NetworkPkg 0.55% <ø> (?)
UefiCpuPkg 4.80% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@VivianNK VivianNK force-pushed the personal/vnowkakeane/2405_capsules branch from 0321798 to e25e3b5 Compare July 10, 2024 21:28
@VivianNK VivianNK requested review from os-d and kuqin12 July 10, 2024 21:28
BaseTools/Scripts/basetools_scripts_bin_path_env.json Outdated Show resolved Hide resolved
MdeModulePkg/Include/Library/CapsuleLib.h Outdated Show resolved Hide resolved
MdeModulePkg/Include/Library/CapsuleLib.h Show resolved Hide resolved
MdeModulePkg/Include/Library/CapsulePersistLib.h Outdated Show resolved Hide resolved
MdeModulePkg/MdeModulePkg.dec Show resolved Hide resolved
MdeModulePkg/MdeModulePkg.dec Outdated Show resolved Hide resolved
MdeModulePkg/MdeModulePkg.dsc Outdated Show resolved Hide resolved
@VivianNK VivianNK force-pushed the personal/vnowkakeane/2405_capsules branch from e25e3b5 to 5e5c464 Compare July 15, 2024 17:26
MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull.c Outdated Show resolved Hide resolved
MdeModulePkg/Library/DxeCapsuleLibFmp/DxeCapsuleLib.c Outdated Show resolved Hide resolved
MdeModulePkg/Library/DxeCapsuleLibFmp/DxeCapsuleLib.c Outdated Show resolved Hide resolved
MdeModulePkg/Library/DxeCapsuleLibFmp/DxeCapsuleLib.c Outdated Show resolved Hide resolved
MdeModulePkg/Library/DxeCapsuleLibFmp/DxeCapsuleLib.c Outdated Show resolved Hide resolved
MdeModulePkg/Library/DxeCapsuleLibFmp/DxeCapsuleLib.c Outdated Show resolved Hide resolved
@VivianNK VivianNK force-pushed the personal/vnowkakeane/2405_capsules branch 2 times, most recently from 1820288 to 5aaf33c Compare July 15, 2024 20:06
Bret Barkelew and others added 4 commits July 15, 2024 14:58
Modifications to capsule infrastructure to allow persistence in media other than "warm reset doesn't destroy ram".
Related work items: #17706456
- Move Capsule infrastructure to TianoCore libs rather than private.
- Add the CapsulePersistLib and remove references to MsCapsuleUpdatePkg.
- Add CapsulePersistLib support to DxeCapsuleLib instance.
- Modify DxeCapsuleProcessLib so that UpdateImageProgress() returns sucess
- Switch debug print to DEBUG_ERROR during capsule processing
@VivianNK VivianNK force-pushed the personal/vnowkakeane/2405_capsules branch from 5aaf33c to f7c82ad Compare July 15, 2024 21:58
@VivianNK VivianNK merged commit bf74087 into microsoft:release/202405 Jul 16, 2024
36 checks passed
@VivianNK VivianNK deleted the personal/vnowkakeane/2405_capsules branch July 16, 2024 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
language:python Pull requests that update Python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants