Skip to content

Commit

Permalink
Consolidate MU_CHANGEs in Memory Protection Code
Browse files Browse the repository at this point in the history
Description

Many changes have been made to CoreInitializeMemoryProtection()
to improve the security state. It's gotten to the point that
the code has been essentially rewritten so to improve
readability and maintainability, consolidate the changes
to MemoryProtectionSupport.c (a Project Mu file).

- [x] Impacts functionality?
  - **Functionality** - Does the change ultimately impact how firmware functions?
  - Examples: Add a new library, publish a new PPI, update an algorithm, ...
- [ ] Impacts security?
  - **Security** - Does the change have a direct security impact on an application,
    flow, or firmware?
  - Examples: Crypto algorithm change, buffer overflow fix, parameter
    validation improvement, ...
- [ ] Breaking change?
  - **Breaking change** - Will anyone consuming this change experience a break
    in build or boot behavior?
  - Examples: Add a new library class, move a module to a different repo, call
    a function in a new library class in a pre-existing module, ...
- [ ] Includes tests?
  - **Tests** - Does the change include any explicit test code?
  - Examples: Unit tests, integration tests, robot tests, ...
- [ ] Includes documentation?
  - **Documentation** - Does the change contain explicit documentation additions
    outside direct code modifications (and comments)?
  - Examples: Update readme file, add feature readme file, link to documentation
    on an a separate Web page, ...

How This Was Tested

Tested by booting to Windows on Q35 and and booting to shell
on SBSA

Integration Instructions

N/A
  • Loading branch information
TaylorBeebe authored and os-d committed Jun 28, 2024
1 parent d0e2016 commit ee65ed3
Show file tree
Hide file tree
Showing 5 changed files with 276 additions and 290 deletions.
3 changes: 2 additions & 1 deletion MdeModulePkg/Core/Dxe/DxeMain.h
Original file line number Diff line number Diff line change
Expand Up @@ -2699,7 +2699,8 @@ CoreInitializeMemoryAttributesTable (
**/
VOID
EFIAPI
CoreInitializeMemoryProtection (
// MU_CHANGE: Use Project Mu CoreInitializeMemoryProtection()
CoreInitializeMemoryProtectionMu (
VOID
);

Expand Down
2 changes: 1 addition & 1 deletion MdeModulePkg/Core/Dxe/DxeMain/DxeMain.c
Original file line number Diff line number Diff line change
Expand Up @@ -479,7 +479,7 @@ DxeMain (
MemoryProfileInstallProtocol ();

CoreInitializeMemoryAttributesTable ();
CoreInitializeMemoryProtection ();
CoreInitializeMemoryProtectionMu (); // MU_CHANGE: Use Project Mu CoreInitializeMemoryProtection()

//
// Get persisted vector hand-off info from GUIDeed HOB again due to HobStart may be updated,
Expand Down
Loading

0 comments on commit ee65ed3

Please sign in to comment.