Skip to content

Commit

Permalink
Bugfix: Fix Tools Def Version Number Incrementation (#638)
Browse files Browse the repository at this point in the history
## Description

The previous PR added the version and description but did not update the
!VERSION value. This PR correctly increments the version number so
consumers are warned to update their Conf directories.

For each item, place an "x" in between `[` and `]` if true. Example:
`[x]`.
_(you can also check items in the GitHub UI)_

- [ ] Impacts functionality?
- **Functionality** - Does the change ultimately impact how firmware
functions?
- Examples: Add a new library, publish a new PPI, update an algorithm,
...
- [ ] Impacts security?
- **Security** - Does the change have a direct security impact on an
application,
    flow, or firmware?
  - Examples: Crypto algorithm change, buffer overflow fix, parameter
    validation improvement, ...
- [ ] Breaking change?
- **Breaking change** - Will anyone consuming this change experience a
break
    in build or boot behavior?
- Examples: Add a new library class, move a module to a different repo,
call
    a function in a new library class in a pre-existing module, ...
- [ ] Includes tests?
  - **Tests** - Does the change include any explicit test code?
  - Examples: Unit tests, integration tests, robot tests, ...
- [ ] Includes documentation?
- **Documentation** - Does the change contain explicit documentation
additions
    outside direct code modifications (and comments)?
- Examples: Update readme file, add feature readme file, link to
documentation
    on an a separate Web page, ...

## How This Was Tested

Tested by kicking off the Q35 build with an old Conf folder

## Integration Instructions

Consumers who build with this update will experience a 30-second timeout
during build on pre-existing clones. To resolve this, simply delete the
Conf folder so the tools_def is refreshed.
  • Loading branch information
TaylorBeebe authored Nov 28, 2023
1 parent b4b92bc commit 710b781
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion BaseTools/Conf/tools_def.template
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
# 2.44 - Add Rust build support
# 2.45 - Enable stack cookies to GCC X64 builds via -fstack-protector flag
#
#!VERSION=2.44
#!VERSION=2.45

IDENTIFIER = Default TOOL_CHAIN_CONF

Expand Down

0 comments on commit 710b781

Please sign in to comment.