Skip to content

Commit

Permalink
Check for Clang and GCC Support When Defining NO_STACK_COOKIE (#640)
Browse files Browse the repository at this point in the history
## Description

Older versions of Clang and GCC don't support the no_stack_protector
attribute. To determine if the attribute is supported for the active
Clang toolchain, the __has_attribute() language extension can be used.
To determine support for GCC, the major version can be checked.
According to the docs, the earliest version which supported the
attribute was v11:
https://gcc.gnu.org/onlinedocs/gcc-11.4.0/gcc/Common-Function-Attributes.html

- [x] Impacts functionality?
- **Functionality** - Does the change ultimately impact how firmware
functions?
- Examples: Add a new library, publish a new PPI, update an algorithm,
...
- [x] Impacts security?
- **Security** - Does the change have a direct security impact on an
application,
    flow, or firmware?
  - Examples: Crypto algorithm change, buffer overflow fix, parameter
    validation improvement, ...
- [ ] Breaking change?
- **Breaking change** - Will anyone consuming this change experience a
break
    in build or boot behavior?
- Examples: Add a new library class, move a module to a different repo,
call
    a function in a new library class in a pre-existing module, ...
- [ ] Includes tests?
  - **Tests** - Does the change include any explicit test code?
  - Examples: Unit tests, integration tests, robot tests, ...
- [ ] Includes documentation?
- **Documentation** - Does the change contain explicit documentation
additions
    outside direct code modifications (and comments)?
- Examples: Update readme file, add feature readme file, link to
documentation
    on an a separate Web page, ...

## How This Was Tested

Tested via using the Clang and GCC toolchains, and building GCC Q35 +
SBSA

## Integration Instructions

N/A
  • Loading branch information
TaylorBeebe authored Nov 30, 2023
1 parent 4e7b1cf commit 0c243fb
Showing 1 changed file with 11 additions and 1 deletion.
12 changes: 11 additions & 1 deletion MdePkg/Include/Base.h
Original file line number Diff line number Diff line change
Expand Up @@ -209,8 +209,18 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
// MU_CHANGE [START]: Stack Cookie Support.
// Omit Function from Stack Overflow Protection.
#ifndef NO_STACK_COOKIE
#if defined (__GNUC__) || defined (__clang__)
#if defined (__clang__)
#if __has_attribute (no_stack_protector)
#define NO_STACK_COOKIE __attribute__ ((no_stack_protector))
#else
#define NO_STACK_COOKIE
#endif
#elif defined (__GNUC__)
#if (__GNUC__ > 10)
#define NO_STACK_COOKIE __attribute__ ((no_stack_protector))
#else
#define NO_STACK_COOKIE
#endif
#elif defined (_MSC_VER)
#define NO_STACK_COOKIE __declspec(safebuffers)
#else
Expand Down

0 comments on commit 0c243fb

Please sign in to comment.