Fix Deprecated icons (#8379) #8576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix Deprecated icons * update remaining glyphs --------- Co-authored-by: Karen Lai <[email protected]>
Merged
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
microsoft-github-policy-service
bot
added
the
needs-triage
karkarl
approved these changes
Jun 22, 2023
|
Hey @Jay-o-Way, wondering if you know what specific settings on the windows OS needed to repro the glyph bug? I am trying to verify the fix with the newly merged changes. |
microsoft-github-policy-service
bot
removed
the
needs-triage
|
@karkarl Not exactly, no. I'm too European for that - I never set my OS to Chinese. Wouldn't dare either, afraid I lose the settings and have to learn to read Chinese. xD [edit] I used Windows Sandbox (first time for everything) set the App Language to Chinese Simplified, Chinese Hong Kong and to Japanese. Then opened an app of which I know for a fact has some of these "invalid" icon codes. Strangely, didn't see much problems. The icons that should give an issue, appear normal. So far my quick test. |
kmahone
added a commit
that referenced
this pull request
Jul 7, 2023
Includes these fixes: * [Fix Deprecated icons ](#8576) * [Fix Voice Access 'Show Bubbles' annotation of WebView2 Content](#8551) * [Add const keyword to resolve warnings (treated as errors) C26462 and C26496](#8567) * [[WebView2] Apply text scale factor to CoreWebView2 content](#8540) * [Fix horizontal scrolling on trackpad](#8403)
ronanlee777
added a commit
to ronanlee777/csharp-microsoft
that referenced
this pull request
Aug 5, 2024
Includes these fixes: * [Fix Deprecated icons ](microsoft/microsoft-ui-xaml#8576) * [Fix Voice Access 'Show Bubbles' annotation of WebView2 Content](microsoft/microsoft-ui-xaml#8551) * [Add const keyword to resolve warnings (treated as errors) C26462 and C26496](microsoft/microsoft-ui-xaml#8567) * [[WebView2] Apply text scale factor to CoreWebView2 content](microsoft/microsoft-ui-xaml#8540) * [Fix horizontal scrolling on trackpad](microsoft/microsoft-ui-xaml#8403)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge of #8379 in main
The WinUI2 'Fix Deprecated Icons' PR was running into issues due to a problem with the pipeline validating builds from forks. To work around that I've merged the PR into a private branch and kicked off a PR into main from here.